1From e75167b426e722ebd11623ae50891d321d245b59 Mon Sep 17 00:00:00 2001
2From: George Burgess IV <[email protected]>
3Date: Mon, 31 Jul 2017 13:55:52 -0700
4Subject: [PATCH 03/20] kcmp_test: Remove useless open mode
5
6Open modes are ignored if the user doesn't want the file to be created:
7http://man7.org/linux/man-pages/man2/open.2.html
8
9Since it's somewhat misleading/potentially indicative of a missing
10O_CREAT/O_TMPFILE, we plan to issue a warning on open calls with useless
11mode bits in the near future. Because -Werror is used in this project
12(thank you!), we need to either make the mode useful, or remove it.
13
14(cherry picked from commit 0bba2e896d09c7ef7b49a409ba5cd869531befa9)
15Bug: 64132680
16Test: mma. New warning no longer appears.
17---
18 tools/testing/selftests/kcmp/kcmp_test.c | 2 +-
19 1 file changed, 1 insertion(+), 1 deletion(-)
20
21diff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c
22index 25110c7c0b3e..d7a8e321bb16 100644
23--- a/tools/testing/selftests/kcmp/kcmp_test.c
24+++ b/tools/testing/selftests/kcmp/kcmp_test.c
25@@ -91,7 +91,7 @@ int main(int argc, char **argv)
26 		ksft_print_header();
27 		ksft_set_plan(3);
28
29-		fd2 = open(kpath, O_RDWR, 0644);
30+		fd2 = open(kpath, O_RDWR);
31 		if (fd2 < 0) {
32 			perror("Can't open file");
33 			ksft_exit_fail();
34--
352.42.0.609.gbb76f46606-goog
36
37