xref: /aosp_15_r20/external/MPAndroidChart/CONTRIBUTING.md (revision f99be7d8b6514e88ac10f2e78d89d406712b34e9)
1> ### Notice
2> *Before you continue, this is the* **ANDROID** *library. If you have an* **iOS** *device, please go here instead*:
3>
4> – https://github.com/danielgindi/Charts
5>
6> They might tell you to come back here, if they do, listen to them and ignore this notice.
7
8# How to contribute
9
10Bug-fixes and features often come from users of the MPAndroidChart library and improve it greatly. We want to keep it as easy as possible to contribute changes that improve the experience for users all around the world. There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
11
12## Creating Issues
13
14There are two main issue templates, one for bugs and another for feature requests. Please use them! You're issue will be much easier to understand, and bugs easier to fix, if you follow the templates. If your issue doesn't fit into those, just use the generic template.
15
16Search existing [issues] to see if your bug has already been reported or if a feature request already exists. Don't forget to remove `is:open` so you see all the issues! If you find that one already exists, use reactions to show how much you care!
17
18## Making Pull Requests
19
20Careful! If you fail to follow these guidlines, you're pull request may be closed, *even if it's really awesome*.
21
22  0. **Search** open [pull requests] AND existing [issues] to make sure what you want to do isn't already being worked on or already has an open pull request.
23  1. **Fork** the repository
24  1. **Create** a new branch based on `master`, and name it according to your changes
25  1. **Add** your commits, they MUST follow the [Commit Style](#commit-style) below
26  1. **Test** your changes by actually running the example app, or create a new example
27  1. **Create** a pull request, following the auto-generated template
28  1. ???
29  1. Profit :money_with_wings:
30
31You are encouraged to use [GitHub Desktop] to inspect your code changes before committing them. It can reveal small changes that might have gone unnoticed, and would be requested for removal before merging.
32
33Check out [#3975](https://github.com/PhilJay/MPAndroidChart/pull/3975) for an example of a good-made-better pull request.
34
35## Commit Style
36
37  * **Make commits of logical units**
38  Don't load your commits with tons of changes, this makes it hard to follow what is happening. However, if you have done a lot of work, and there are commits and merges all over the place, squash them down into fewer commits.
39
40  * **Conform to the code style**
41  It's easy, just look around!
42
43  * **Write good commit messages**
44  You may prefer [Tim Pope's style], you might like the [commitizen-friendly] way. Regardless of the color you pick, you MUST stay within the lines!
45  ```
46The commit title CANNOT exceed 50 characters
47
48The body of the message comes after an empty new line, and describes the
49changes more thoroughly. If the change is obvious and self-explanatory
50from the title, you can omit the body. You should describe all changes
51if many were made, or maybe some trickery that only code wizards can
52understand.
53
54Be polite and wrap your lines to 72 characters, but if you prefer going
55to 100 characters then I guess we can't stop you.
56```
57
58## Final Notes
59
60Thanks for reading the contributing file! Have some cake! :cake:
61
62[issues]: https://github.com/PhilJay/MPAndroidChart/issues
63[pull requests]: https://github.com/PhilJay/MPAndroidChart/pulls
64[GitHub Desktop]: https://desktop.github.com/
65[Tim Pope's style]: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
66[commitizen-friendly]: https://github.com/commitizen/cz-cli
67