1*ec63e07aSXin Li // Copyright 2019 Google LLC
2*ec63e07aSXin Li //
3*ec63e07aSXin Li // Licensed under the Apache License, Version 2.0 (the "License");
4*ec63e07aSXin Li // you may not use this file except in compliance with the License.
5*ec63e07aSXin Li // You may obtain a copy of the License at
6*ec63e07aSXin Li //
7*ec63e07aSXin Li // https://www.apache.org/licenses/LICENSE-2.0
8*ec63e07aSXin Li //
9*ec63e07aSXin Li // Unless required by applicable law or agreed to in writing, software
10*ec63e07aSXin Li // distributed under the License is distributed on an "AS IS" BASIS,
11*ec63e07aSXin Li // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12*ec63e07aSXin Li // See the License for the specific language governing permissions and
13*ec63e07aSXin Li // limitations under the License.
14*ec63e07aSXin Li
15*ec63e07aSXin Li #include "sandboxed_api/sandbox2/notify.h"
16*ec63e07aSXin Li
17*ec63e07aSXin Li #include <sys/types.h>
18*ec63e07aSXin Li #include <syscall.h>
19*ec63e07aSXin Li
20*ec63e07aSXin Li #include <memory>
21*ec63e07aSXin Li #include <string>
22*ec63e07aSXin Li #include <utility>
23*ec63e07aSXin Li #include <vector>
24*ec63e07aSXin Li
25*ec63e07aSXin Li #include "gmock/gmock.h"
26*ec63e07aSXin Li #include "gtest/gtest.h"
27*ec63e07aSXin Li #include "absl/log/log.h"
28*ec63e07aSXin Li #include "absl/strings/str_join.h"
29*ec63e07aSXin Li #include "absl/strings/string_view.h"
30*ec63e07aSXin Li #include "sandboxed_api/sandbox2/comms.h"
31*ec63e07aSXin Li #include "sandboxed_api/sandbox2/executor.h"
32*ec63e07aSXin Li #include "sandboxed_api/sandbox2/policy.h"
33*ec63e07aSXin Li #include "sandboxed_api/sandbox2/policybuilder.h"
34*ec63e07aSXin Li #include "sandboxed_api/sandbox2/sandbox2.h"
35*ec63e07aSXin Li #include "sandboxed_api/sandbox2/syscall.h"
36*ec63e07aSXin Li #include "sandboxed_api/sandbox2/trace_all_syscalls.h"
37*ec63e07aSXin Li #include "sandboxed_api/testing.h"
38*ec63e07aSXin Li
39*ec63e07aSXin Li namespace sandbox2 {
40*ec63e07aSXin Li namespace {
41*ec63e07aSXin Li
42*ec63e07aSXin Li using ::sapi::CreateDefaultPermissiveTestPolicy;
43*ec63e07aSXin Li using ::sapi::GetTestSourcePath;
44*ec63e07aSXin Li using ::testing::Eq;
45*ec63e07aSXin Li
46*ec63e07aSXin Li // Allow typical syscalls and call SECCOMP_RET_TRACE for personality syscall,
47*ec63e07aSXin Li // chosen because unlikely to be called by a regular program.
NotifyTestcasePolicy(absl::string_view path)48*ec63e07aSXin Li std::unique_ptr<Policy> NotifyTestcasePolicy(absl::string_view path) {
49*ec63e07aSXin Li return CreateDefaultPermissiveTestPolicy(path)
50*ec63e07aSXin Li .AddPolicyOnSyscall(__NR_personality, {SANDBOX2_TRACE})
51*ec63e07aSXin Li .BuildOrDie();
52*ec63e07aSXin Li }
53*ec63e07aSXin Li
54*ec63e07aSXin Li // If syscall and its arguments don't match the expected ones, return the
55*ec63e07aSXin Li // opposite of the requested values (allow/disallow) to indicate an error.
56*ec63e07aSXin Li class PersonalityNotify : public Notify {
57*ec63e07aSXin Li public:
PersonalityNotify(bool allow)58*ec63e07aSXin Li explicit PersonalityNotify(bool allow) : allow_(allow) {}
59*ec63e07aSXin Li
EventSyscallTrap(const Syscall & syscall)60*ec63e07aSXin Li bool EventSyscallTrap(const Syscall& syscall) override {
61*ec63e07aSXin Li if (syscall.nr() != __NR_personality) {
62*ec63e07aSXin Li LOG(ERROR) << "kSyscall==" << syscall.nr();
63*ec63e07aSXin Li return (!allow_);
64*ec63e07aSXin Li }
65*ec63e07aSXin Li Syscall::Args expected_args = {0x1, 0x2, 0x3, 0x4, 0x5, 0x6};
66*ec63e07aSXin Li if (syscall.args() != expected_args) {
67*ec63e07aSXin Li LOG(ERROR) << "args=={" << absl::StrJoin(syscall.args(), ", ") << "}";
68*ec63e07aSXin Li return (!allow_);
69*ec63e07aSXin Li }
70*ec63e07aSXin Li return allow_;
71*ec63e07aSXin Li }
72*ec63e07aSXin Li
73*ec63e07aSXin Li private:
74*ec63e07aSXin Li // The intended return value from EventSyscallTrap in case all registers
75*ec63e07aSXin Li // match.
76*ec63e07aSXin Li bool allow_;
77*ec63e07aSXin Li };
78*ec63e07aSXin Li
79*ec63e07aSXin Li // Print the newly created PID, and exchange data over Comms before sandboxing.
80*ec63e07aSXin Li class PidCommsNotify : public Notify {
81*ec63e07aSXin Li public:
EventStarted(pid_t pid,Comms * comms)82*ec63e07aSXin Li bool EventStarted(pid_t pid, Comms* comms) final {
83*ec63e07aSXin Li LOG(INFO) << "The newly created PID: " << pid;
84*ec63e07aSXin Li bool v;
85*ec63e07aSXin Li return comms->RecvBool(&v);
86*ec63e07aSXin Li }
87*ec63e07aSXin Li };
88*ec63e07aSXin Li
89*ec63e07aSXin Li // Test EventSyscallTrap on personality syscall and allow it.
TEST(NotifyTest,AllowPersonality)90*ec63e07aSXin Li TEST(NotifyTest, AllowPersonality) {
91*ec63e07aSXin Li const std::string path = GetTestSourcePath("sandbox2/testcases/personality");
92*ec63e07aSXin Li std::vector<std::string> args = {path};
93*ec63e07aSXin Li Sandbox2 s2(std::make_unique<Executor>(path, args),
94*ec63e07aSXin Li NotifyTestcasePolicy(path),
95*ec63e07aSXin Li std::make_unique<PersonalityNotify>(/*allow=*/true));
96*ec63e07aSXin Li auto result = s2.Run();
97*ec63e07aSXin Li
98*ec63e07aSXin Li ASSERT_THAT(result.final_status(), Eq(Result::OK));
99*ec63e07aSXin Li EXPECT_THAT(result.reason_code(), Eq(22));
100*ec63e07aSXin Li }
101*ec63e07aSXin Li
102*ec63e07aSXin Li // Test EventSyscallTrap on personality syscall and disallow it.
TEST(NotifyTest,DisallowPersonality)103*ec63e07aSXin Li TEST(NotifyTest, DisallowPersonality) {
104*ec63e07aSXin Li const std::string path = GetTestSourcePath("sandbox2/testcases/personality");
105*ec63e07aSXin Li std::vector<std::string> args = {path};
106*ec63e07aSXin Li Sandbox2 s2(std::make_unique<Executor>(path, args),
107*ec63e07aSXin Li NotifyTestcasePolicy(path),
108*ec63e07aSXin Li std::make_unique<PersonalityNotify>(/*allow=*/false));
109*ec63e07aSXin Li auto result = s2.Run();
110*ec63e07aSXin Li
111*ec63e07aSXin Li ASSERT_THAT(result.final_status(), Eq(Result::VIOLATION));
112*ec63e07aSXin Li EXPECT_THAT(result.reason_code(), Eq(__NR_personality));
113*ec63e07aSXin Li }
114*ec63e07aSXin Li
115*ec63e07aSXin Li // Test EventStarted by exchanging data after started but before sandboxed.
TEST(NotifyTest,PrintPidAndComms)116*ec63e07aSXin Li TEST(NotifyTest, PrintPidAndComms) {
117*ec63e07aSXin Li const std::string path = GetTestSourcePath("sandbox2/testcases/pidcomms");
118*ec63e07aSXin Li std::vector<std::string> args = {path};
119*ec63e07aSXin Li auto executor = std::make_unique<Executor>(path, args);
120*ec63e07aSXin Li executor->set_enable_sandbox_before_exec(false);
121*ec63e07aSXin Li
122*ec63e07aSXin Li Sandbox2 s2(std::move(executor), NotifyTestcasePolicy(path),
123*ec63e07aSXin Li std::make_unique<PidCommsNotify>());
124*ec63e07aSXin Li auto result = s2.Run();
125*ec63e07aSXin Li
126*ec63e07aSXin Li ASSERT_THAT(result.final_status(), Eq(Result::OK));
127*ec63e07aSXin Li EXPECT_THAT(result.reason_code(), Eq(33));
128*ec63e07aSXin Li }
129*ec63e07aSXin Li
130*ec63e07aSXin Li // Test EventSyscallTrap on personality syscall through TraceAllSyscalls
TEST(NotifyTest,TraceAllAllowPersonality)131*ec63e07aSXin Li TEST(NotifyTest, TraceAllAllowPersonality) {
132*ec63e07aSXin Li const std::string path = GetTestSourcePath("sandbox2/testcases/personality");
133*ec63e07aSXin Li std::vector<std::string> args = {path};
134*ec63e07aSXin Li auto policy = CreateDefaultPermissiveTestPolicy(path)
135*ec63e07aSXin Li .DefaultAction(TraceAllSyscalls())
136*ec63e07aSXin Li .BuildOrDie();
137*ec63e07aSXin Li Sandbox2 s2(std::make_unique<Executor>(path, args),
138*ec63e07aSXin Li NotifyTestcasePolicy(path),
139*ec63e07aSXin Li std::make_unique<PersonalityNotify>(/*allow=*/true));
140*ec63e07aSXin Li auto result = s2.Run();
141*ec63e07aSXin Li
142*ec63e07aSXin Li ASSERT_THAT(result.final_status(), Eq(Result::OK));
143*ec63e07aSXin Li EXPECT_THAT(result.reason_code(), Eq(22));
144*ec63e07aSXin Li }
145*ec63e07aSXin Li
146*ec63e07aSXin Li } // namespace
147*ec63e07aSXin Li } // namespace sandbox2
148