1*61c4878aSAndroid Build Coastguard Worker# Copyright 2024 The Pigweed Authors 2*61c4878aSAndroid Build Coastguard Worker# 3*61c4878aSAndroid Build Coastguard Worker# Licensed under the Apache License, Version 2.0 (the "License"); you may not 4*61c4878aSAndroid Build Coastguard Worker# use this file except in compliance with the License. You may obtain a copy of 5*61c4878aSAndroid Build Coastguard Worker# the License at 6*61c4878aSAndroid Build Coastguard Worker# 7*61c4878aSAndroid Build Coastguard Worker# https://www.apache.org/licenses/LICENSE-2.0 8*61c4878aSAndroid Build Coastguard Worker# 9*61c4878aSAndroid Build Coastguard Worker# Unless required by applicable law or agreed to in writing, software 10*61c4878aSAndroid Build Coastguard Worker# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT 11*61c4878aSAndroid Build Coastguard Worker# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the 12*61c4878aSAndroid Build Coastguard Worker# License for the specific language governing permissions and limitations under 13*61c4878aSAndroid Build Coastguard Worker# the License. 14*61c4878aSAndroid Build Coastguard Worker 15*61c4878aSAndroid Build Coastguard Workerload("@bazel_skylib//rules:common_settings.bzl", "string_flag") 16*61c4878aSAndroid Build Coastguard Workerload( 17*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//cc_toolchain:defs.bzl", 18*61c4878aSAndroid Build Coastguard Worker "pw_cc_feature", 19*61c4878aSAndroid Build Coastguard Worker "pw_cc_flag_set", 20*61c4878aSAndroid Build Coastguard Worker) 21*61c4878aSAndroid Build Coastguard Worker 22*61c4878aSAndroid Build Coastguard Workerpackage(default_visibility = ["//visibility:public"]) 23*61c4878aSAndroid Build Coastguard Worker 24*61c4878aSAndroid Build Coastguard Worker# The common set of warnings for clang and arm_gcc. 25*61c4878aSAndroid Build Coastguard Workerpw_cc_flag_set( 26*61c4878aSAndroid Build Coastguard Worker name = "common_warnings", 27*61c4878aSAndroid Build Coastguard Worker actions = [ 28*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_c_compiler_actions", 29*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_cpp_compiler_actions", 30*61c4878aSAndroid Build Coastguard Worker ], 31*61c4878aSAndroid Build Coastguard Worker flags = [ 32*61c4878aSAndroid Build Coastguard Worker "-Wall", 33*61c4878aSAndroid Build Coastguard Worker "-Wextra", 34*61c4878aSAndroid Build Coastguard Worker "-Wimplicit-fallthrough", 35*61c4878aSAndroid Build Coastguard Worker "-Wcast-qual", 36*61c4878aSAndroid Build Coastguard Worker "-Wpointer-arith", 37*61c4878aSAndroid Build Coastguard Worker "-Wshadow", 38*61c4878aSAndroid Build Coastguard Worker "-Wredundant-decls", 39*61c4878aSAndroid Build Coastguard Worker # TODO: b/259746255 - Enable implicit conversion warnings once fixed. 40*61c4878aSAndroid Build Coastguard Worker # "-Wconversion", 41*61c4878aSAndroid Build Coastguard Worker # Make all warnings errors, except for the exemptions below. 42*61c4878aSAndroid Build Coastguard Worker "-Werror", 43*61c4878aSAndroid Build Coastguard Worker "-Wno-error=cpp", # preprocessor #warning statement 44*61c4878aSAndroid Build Coastguard Worker "-Wno-error=deprecated-declarations", # [[deprecated]] attribute 45*61c4878aSAndroid Build Coastguard Worker ], 46*61c4878aSAndroid Build Coastguard Worker) 47*61c4878aSAndroid Build Coastguard Worker 48*61c4878aSAndroid Build Coastguard Worker# Enables colors in compiler diagnostics. This uses the GCC spelling of the 49*61c4878aSAndroid Build Coastguard Worker# flag, which Clang supports as an undocumented extension. 50*61c4878aSAndroid Build Coastguard Workerpw_cc_flag_set( 51*61c4878aSAndroid Build Coastguard Worker name = "color_diagnostics", 52*61c4878aSAndroid Build Coastguard Worker actions = [ 53*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_asm_actions", 54*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_c_compiler_actions", 55*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_cpp_compiler_actions", 56*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_link_actions", 57*61c4878aSAndroid Build Coastguard Worker ], 58*61c4878aSAndroid Build Coastguard Worker flags = ["-fdiagnostics-color"], 59*61c4878aSAndroid Build Coastguard Worker) 60*61c4878aSAndroid Build Coastguard Worker 61*61c4878aSAndroid Build Coastguard Worker# This config contains warnings that are enabled for upstream Pigweed. 62*61c4878aSAndroid Build Coastguard Worker# This config MUST NOT be used downstream to allow for warnings to be 63*61c4878aSAndroid Build Coastguard Worker# added in the future without breaking downstream. 64*61c4878aSAndroid Build Coastguard Workerpw_cc_flag_set( 65*61c4878aSAndroid Build Coastguard Worker name = "internal_strict_warnings_flags", 66*61c4878aSAndroid Build Coastguard Worker actions = [ 67*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_c_compiler_actions", 68*61c4878aSAndroid Build Coastguard Worker "@pw_toolchain//actions:all_cpp_compiler_actions", 69*61c4878aSAndroid Build Coastguard Worker ], 70*61c4878aSAndroid Build Coastguard Worker flags = [ 71*61c4878aSAndroid Build Coastguard Worker "-Wswitch-enum", 72*61c4878aSAndroid Build Coastguard Worker "-Wextra-semi", 73*61c4878aSAndroid Build Coastguard Worker # TODO: b/361229275 - Add -Wshadow-all, but for Clang only, since GCC 74*61c4878aSAndroid Build Coastguard Worker # does not support it. 75*61c4878aSAndroid Build Coastguard Worker # "-Wshadow-all", 76*61c4878aSAndroid Build Coastguard Worker ] + select({ 77*61c4878aSAndroid Build Coastguard Worker "@platforms//os:windows": [], 78*61c4878aSAndroid Build Coastguard Worker # TODO: b/243069432 - Enable pedantic warnings on Windows once passing. 79*61c4878aSAndroid Build Coastguard Worker "//conditions:default": [":pedantic_warnings"], 80*61c4878aSAndroid Build Coastguard Worker }), 81*61c4878aSAndroid Build Coastguard Worker visibility = ["//:__subpackages__"], 82*61c4878aSAndroid Build Coastguard Worker) 83*61c4878aSAndroid Build Coastguard Worker 84*61c4878aSAndroid Build Coastguard Worker# Add `--features=internal_strict_warnings` to your Bazel invocation to enable. 85*61c4878aSAndroid Build Coastguard Workerpw_cc_feature( 86*61c4878aSAndroid Build Coastguard Worker name = "internal_strict_warnings", 87*61c4878aSAndroid Build Coastguard Worker enabled = False, 88*61c4878aSAndroid Build Coastguard Worker feature_name = "internal_strict_warnings", 89*61c4878aSAndroid Build Coastguard Worker flag_sets = [":internal_strict_warnings_flags"], 90*61c4878aSAndroid Build Coastguard Worker visibility = ["//:__subpackages__"], 91*61c4878aSAndroid Build Coastguard Worker) 92*61c4878aSAndroid Build Coastguard Worker 93*61c4878aSAndroid Build Coastguard Workerstring_flag( 94*61c4878aSAndroid Build Coastguard Worker name = "cxx_standard", 95*61c4878aSAndroid Build Coastguard Worker build_setting_default = "20", 96*61c4878aSAndroid Build Coastguard Worker values = [ 97*61c4878aSAndroid Build Coastguard Worker "17", 98*61c4878aSAndroid Build Coastguard Worker "20", 99*61c4878aSAndroid Build Coastguard Worker ], 100*61c4878aSAndroid Build Coastguard Worker) 101*61c4878aSAndroid Build Coastguard Worker 102*61c4878aSAndroid Build Coastguard Workerconfig_setting( 103*61c4878aSAndroid Build Coastguard Worker name = "c++17_enabled", 104*61c4878aSAndroid Build Coastguard Worker flag_values = { 105*61c4878aSAndroid Build Coastguard Worker ":cxx_standard": "17", 106*61c4878aSAndroid Build Coastguard Worker }, 107*61c4878aSAndroid Build Coastguard Worker) 108*61c4878aSAndroid Build Coastguard Worker 109*61c4878aSAndroid Build Coastguard Workerpw_cc_feature( 110*61c4878aSAndroid Build Coastguard Worker name = "c++17_feature", 111*61c4878aSAndroid Build Coastguard Worker enabled = select({ 112*61c4878aSAndroid Build Coastguard Worker ":c++17_enabled": True, 113*61c4878aSAndroid Build Coastguard Worker "//conditions:default": False, 114*61c4878aSAndroid Build Coastguard Worker }), 115*61c4878aSAndroid Build Coastguard Worker feature_name = "c++17", 116*61c4878aSAndroid Build Coastguard Worker flag_sets = ["@pw_toolchain//flag_sets:c++17"], 117*61c4878aSAndroid Build Coastguard Worker) 118*61c4878aSAndroid Build Coastguard Worker 119*61c4878aSAndroid Build Coastguard Workerconfig_setting( 120*61c4878aSAndroid Build Coastguard Worker name = "c++20_enabled", 121*61c4878aSAndroid Build Coastguard Worker flag_values = { 122*61c4878aSAndroid Build Coastguard Worker ":cxx_standard": "20", 123*61c4878aSAndroid Build Coastguard Worker }, 124*61c4878aSAndroid Build Coastguard Worker) 125*61c4878aSAndroid Build Coastguard Worker 126*61c4878aSAndroid Build Coastguard Workerpw_cc_feature( 127*61c4878aSAndroid Build Coastguard Worker name = "c++20_feature", 128*61c4878aSAndroid Build Coastguard Worker enabled = select({ 129*61c4878aSAndroid Build Coastguard Worker ":c++20_enabled": True, 130*61c4878aSAndroid Build Coastguard Worker "//conditions:default": False, 131*61c4878aSAndroid Build Coastguard Worker }), 132*61c4878aSAndroid Build Coastguard Worker feature_name = "c++20", 133*61c4878aSAndroid Build Coastguard Worker flag_sets = ["@pw_toolchain//flag_sets:c++20"], 134*61c4878aSAndroid Build Coastguard Worker) 135