1*4a64e381SAndroid Build Coastguard WorkerFrom 8ebfeaf55ab364a1e51a3438dfa9a742a01b8d36 Mon Sep 17 00:00:00 2001 2*4a64e381SAndroid Build Coastguard WorkerMessage-ID: <8ebfeaf55ab364a1e51a3438dfa9a742a01b8d36.1687508149.git.stefan@agner.ch> 3*4a64e381SAndroid Build Coastguard WorkerIn-Reply-To: <e136dcdcdd93ef32ada981e89c195905eb809eea.1687508149.git.stefan@agner.ch> 4*4a64e381SAndroid Build Coastguard WorkerReferences: <e136dcdcdd93ef32ada981e89c195905eb809eea.1687508149.git.stefan@agner.ch> 5*4a64e381SAndroid Build Coastguard WorkerFrom: Nate Karstens <[email protected]> 6*4a64e381SAndroid Build Coastguard WorkerDate: Wed, 9 Aug 2017 09:16:58 -0500 7*4a64e381SAndroid Build Coastguard WorkerSubject: [PATCH] Mark deleted interfaces as being changed 8*4a64e381SAndroid Build Coastguard Worker 9*4a64e381SAndroid Build Coastguard WorkerNetlink notification handling ignores messages for deleted links, 10*4a64e381SAndroid Build Coastguard WorkerRTM_DELLINK. It does handle RTM_GETLINK. According to libnl docu- 11*4a64e381SAndroid Build Coastguard Workermentation (http://www.infradead.org/~tgr/libnl/doc/route.html) 12*4a64e381SAndroid Build Coastguard WorkerRTM_DELLINK can be sent by the kernel, but RTM_GETLINK cannot. 13*4a64e381SAndroid Build Coastguard WorkerThere was likely a mixup in the original implementation, so this 14*4a64e381SAndroid Build Coastguard Workerchange replaces handling for RTM_GETLINK with RTM_DELLINK. 15*4a64e381SAndroid Build Coastguard Worker 16*4a64e381SAndroid Build Coastguard WorkerTesting and Verification Instructions: 17*4a64e381SAndroid Build Coastguard Worker 1. Use ip-link to add and remove a VLAN interface and verify 18*4a64e381SAndroid Build Coastguard Worker that mDNSResponder handles the deleted link. 19*4a64e381SAndroid Build Coastguard Worker 20*4a64e381SAndroid Build Coastguard WorkerUpstream-Status: Submitted [[email protected]] 21*4a64e381SAndroid Build Coastguard Worker 22*4a64e381SAndroid Build Coastguard WorkerSigned-off-by: Nate Karstens <[email protected]> 23*4a64e381SAndroid Build Coastguard WorkerSigned-off-by: Alex Kiernan <[email protected]> 24*4a64e381SAndroid Build Coastguard Worker--- 25*4a64e381SAndroid Build Coastguard Worker mDNSPosix/mDNSPosix.c | 2 +- 26*4a64e381SAndroid Build Coastguard Worker 1 file changed, 1 insertion(+), 1 deletion(-) 27*4a64e381SAndroid Build Coastguard Worker 28*4a64e381SAndroid Build Coastguard Workerdiff --git a/mDNSPosix/mDNSPosix.c b/mDNSPosix/mDNSPosix.c 29*4a64e381SAndroid Build Coastguard Workerindex ad7000d..010f266 100644 30*4a64e381SAndroid Build Coastguard Worker--- a/mDNSPosix/mDNSPosix.c 31*4a64e381SAndroid Build Coastguard Worker+++ b/mDNSPosix/mDNSPosix.c 32*4a64e381SAndroid Build Coastguard Worker@@ -1714,7 +1714,7 @@ mDNSlocal void ProcessRoutingNotification(int sd, GenLinkedList *change 33*4a64e381SAndroid Build Coastguard Worker #endif 34*4a64e381SAndroid Build Coastguard Worker 35*4a64e381SAndroid Build Coastguard Worker // Process the NetLink message 36*4a64e381SAndroid Build Coastguard Worker- if (pNLMsg->nlmsg_type == RTM_GETLINK || pNLMsg->nlmsg_type == RTM_NEWLINK) 37*4a64e381SAndroid Build Coastguard Worker+ if (pNLMsg->nlmsg_type == RTM_DELLINK || pNLMsg->nlmsg_type == RTM_NEWLINK) 38*4a64e381SAndroid Build Coastguard Worker AddInterfaceIndexToList(changedInterfaces, ((struct ifinfomsg*) NLMSG_DATA(pNLMsg))->ifi_index); 39*4a64e381SAndroid Build Coastguard Worker else if (pNLMsg->nlmsg_type == RTM_DELADDR || pNLMsg->nlmsg_type == RTM_NEWADDR) 40*4a64e381SAndroid Build Coastguard Worker AddInterfaceIndexToList(changedInterfaces, ((struct ifaddrmsg*) NLMSG_DATA(pNLMsg))->ifa_index); 41*4a64e381SAndroid Build Coastguard Worker-- 42*4a64e381SAndroid Build Coastguard Worker2.41.0 43*4a64e381SAndroid Build Coastguard Worker 44