xref: /aosp_15_r20/external/nullaway/README.md (revision f50c306653bc89b8210ce6c9e0b0b44fc134bc03)
1*f50c3066SAndroid Build Coastguard Worker## NullAway: Fast Annotation-Based Null Checking for Java [![Build Status](https://github.com/uber/nullaway/actions/workflows/continuous-integration.yml/badge.svg)](https://github.com/uber/nullaway/actions/workflows/continuous-integration.yml) [![Coverage Status](https://codecov.io/github/uber/NullAway/coverage.svg?branch=master)](https://codecov.io/github/uber/NullAway?branch=master)
2*f50c3066SAndroid Build Coastguard Worker
3*f50c3066SAndroid Build Coastguard WorkerNullAway is a tool to help eliminate `NullPointerException`s (NPEs) in your Java code.  To use NullAway, first add `@Nullable` annotations in your code wherever a field, method parameter, or return value may be `null`.  Given these annotations, NullAway performs a series of type-based, local checks to ensure that any pointer that gets dereferenced in your code cannot be `null`.  NullAway is similar to the type-based nullability checking in the Kotlin and Swift languages, and the [Checker Framework](https://checkerframework.org/) and [Eradicate](https://fbinfer.com/docs/checker-eradicate/) null checkers for Java.
4*f50c3066SAndroid Build Coastguard Worker
5*f50c3066SAndroid Build Coastguard WorkerNullAway is *fast*.  It is built as a plugin to [Error Prone](http://errorprone.info/) and can run on every single build of your code.  In our measurements, the build-time overhead of running NullAway is usually less than 10%.  NullAway is also *practical*: it does not prevent all possible NPEs in your code, but it catches most of the NPEs we have observed in production while imposing a reasonable annotation burden, giving a great "bang for your buck."
6*f50c3066SAndroid Build Coastguard Worker
7*f50c3066SAndroid Build Coastguard Worker## Installation
8*f50c3066SAndroid Build Coastguard Worker
9*f50c3066SAndroid Build Coastguard Worker### Overview
10*f50c3066SAndroid Build Coastguard Worker
11*f50c3066SAndroid Build Coastguard WorkerNullAway requires that you build your code with [Error Prone](http://errorprone.info), version 2.10.0 or higher.  See the [Error Prone documentation](http://errorprone.info/docs/installation) for instructions on getting started with Error Prone and integration with your build system.  The instructions below assume you are using Gradle; see [the docs](https://github.com/uber/NullAway/wiki/Configuration#other-build-systems) for discussion of other build systems.
12*f50c3066SAndroid Build Coastguard Worker
13*f50c3066SAndroid Build Coastguard Worker### Gradle
14*f50c3066SAndroid Build Coastguard Worker
15*f50c3066SAndroid Build Coastguard Worker#### Java (non-Android)
16*f50c3066SAndroid Build Coastguard Worker
17*f50c3066SAndroid Build Coastguard WorkerTo integrate NullAway into your non-Android Java project, add the following to your `build.gradle` file:
18*f50c3066SAndroid Build Coastguard Worker
19*f50c3066SAndroid Build Coastguard Worker```gradle
20*f50c3066SAndroid Build Coastguard Workerplugins {
21*f50c3066SAndroid Build Coastguard Worker  // we assume you are already using the Java plugin
22*f50c3066SAndroid Build Coastguard Worker  id "net.ltgt.errorprone" version "<plugin version>"
23*f50c3066SAndroid Build Coastguard Worker}
24*f50c3066SAndroid Build Coastguard Worker
25*f50c3066SAndroid Build Coastguard Workerdependencies {
26*f50c3066SAndroid Build Coastguard Worker  errorprone "com.uber.nullaway:nullaway:<NullAway version>"
27*f50c3066SAndroid Build Coastguard Worker
28*f50c3066SAndroid Build Coastguard Worker  // Optional, some source of nullability annotations.
29*f50c3066SAndroid Build Coastguard Worker  // Not required on Android if you use the support
30*f50c3066SAndroid Build Coastguard Worker  // library nullability annotations.
31*f50c3066SAndroid Build Coastguard Worker  compileOnly "com.google.code.findbugs:jsr305:3.0.2"
32*f50c3066SAndroid Build Coastguard Worker
33*f50c3066SAndroid Build Coastguard Worker  errorprone "com.google.errorprone:error_prone_core:<Error Prone version>"
34*f50c3066SAndroid Build Coastguard Worker}
35*f50c3066SAndroid Build Coastguard Worker
36*f50c3066SAndroid Build Coastguard Workerimport net.ltgt.gradle.errorprone.CheckSeverity
37*f50c3066SAndroid Build Coastguard Worker
38*f50c3066SAndroid Build Coastguard Workertasks.withType(JavaCompile) {
39*f50c3066SAndroid Build Coastguard Worker  // remove the if condition if you want to run NullAway on test code
40*f50c3066SAndroid Build Coastguard Worker  if (!name.toLowerCase().contains("test")) {
41*f50c3066SAndroid Build Coastguard Worker    options.errorprone {
42*f50c3066SAndroid Build Coastguard Worker      check("NullAway", CheckSeverity.ERROR)
43*f50c3066SAndroid Build Coastguard Worker      option("NullAway:AnnotatedPackages", "com.uber")
44*f50c3066SAndroid Build Coastguard Worker    }
45*f50c3066SAndroid Build Coastguard Worker  }
46*f50c3066SAndroid Build Coastguard Worker}
47*f50c3066SAndroid Build Coastguard Worker```
48*f50c3066SAndroid Build Coastguard Worker
49*f50c3066SAndroid Build Coastguard WorkerLet's walk through this script step by step.  The `plugins` section pulls in the [Gradle Error Prone plugin](https://github.com/tbroyer/gradle-errorprone-plugin) for Error Prone integration.
50*f50c3066SAndroid Build Coastguard Worker
51*f50c3066SAndroid Build Coastguard WorkerIn `dependencies`, the first `errorprone` line loads NullAway, and the `compileOnly` line loads a [JSR 305](https://jcp.org/en/jsr/detail?id=305) library which provides a suitable `@Nullable` annotation (`javax.annotation.Nullable`).  NullAway allows for any `@Nullable` annotation to be used, so, e.g., `@Nullable` from the Android Support Library or JetBrains annotations is also fine. The second `errorprone` line sets the version of Error Prone is used.
52*f50c3066SAndroid Build Coastguard Worker
53*f50c3066SAndroid Build Coastguard WorkerFinally, in the `tasks.withType(JavaCompile)` section, we pass some configuration options to NullAway.  First `check("NullAway", CheckSeverity.ERROR)` sets NullAway issues to the error level (it's equivalent to the `-Xep:NullAway:ERROR` standard Error Prone argument); by default NullAway emits warnings.  Then, `option("NullAway:AnnotatedPackages", "com.uber")` (equivalent to the `-XepOpt:NullAway:AnnotatedPackages=com.uber` standard Error Prone argument) tells NullAway that source code in packages under the `com.uber` namespace should be checked for null dereferences and proper usage of `@Nullable` annotations, and that class files in these packages should be assumed to have correct usage of `@Nullable` (see [the docs](https://github.com/uber/NullAway/wiki/Configuration) for more detail).  NullAway requires at least the `AnnotatedPackages` configuration argument to run, in order to distinguish between annotated and unannotated code.  See [the configuration docs](https://github.com/uber/NullAway/wiki/Configuration) for other useful configuration options.  For even simpler configuration of NullAway options, use the [Gradle NullAway plugin](https://github.com/tbroyer/gradle-nullaway-plugin).
54*f50c3066SAndroid Build Coastguard Worker
55*f50c3066SAndroid Build Coastguard WorkerWe recommend addressing all the issues that Error Prone reports, particularly those reported as errors (rather than warnings).  But, if you'd like to try out NullAway without running other Error Prone checks, you can use `options.errorprone.disableAllChecks` (equivalent to passing `"-XepDisableAllChecks"` to the compiler, before the NullAway-specific arguments).
56*f50c3066SAndroid Build Coastguard Worker
57*f50c3066SAndroid Build Coastguard WorkerSnapshots of the development version are available in [Sonatype's snapshots repository][snapshots].
58*f50c3066SAndroid Build Coastguard Worker
59*f50c3066SAndroid Build Coastguard Worker#### Android
60*f50c3066SAndroid Build Coastguard Worker
61*f50c3066SAndroid Build Coastguard WorkerVersions 3.0.0 and later of the Gradle Error Prone Plugin [no longer support Android](https://github.com/tbroyer/gradle-errorprone-plugin/releases/tag/v3.0.0).  So if you're using a recent version of this plugin, you'll need to add some further configuration to run Error Prone and NullAway.  Our [sample app `build.gradle` file](https://github.com/uber/NullAway/blob/master/sample-app/build.gradle) shows one way to do this, but your Android project may require tweaks.  Alternately, 2.x versions of the Gradle Error Prone Plugin still support Android and may still work with your project.
62*f50c3066SAndroid Build Coastguard Worker
63*f50c3066SAndroid Build Coastguard WorkerBeyond that, compared to the Java configuration, the `com.google.code.findbugs:jsr305:3.0.2` dependency can be removed; you can use the `android.support.annotation.Nullable` annotation from the Android Support library instead.
64*f50c3066SAndroid Build Coastguard Worker
65*f50c3066SAndroid Build Coastguard Worker#### Annotation Processors / Generated Code
66*f50c3066SAndroid Build Coastguard Worker
67*f50c3066SAndroid Build Coastguard WorkerSome annotation processors like [Dagger](https://google.github.io/dagger/) and [AutoValue](https://github.com/google/auto/tree/master/value) generate code into the same package namespace as your own code.  This can cause problems when setting NullAway to the `ERROR` level as suggested above, since errors in this generated code will block the build.  Currently the best solution to this problem is to completely disable Error Prone on generated code, using the `-XepExcludedPaths` option added in Error Prone 2.1.3 (documented [here](http://errorprone.info/docs/flags), use `options.errorprone.excludedPaths=` in Gradle).  To use, figure out which directory contains the generated code, and add that directory to the excluded path regex.
68*f50c3066SAndroid Build Coastguard Worker
69*f50c3066SAndroid Build Coastguard Worker**Note for Dagger users**: Dagger versions older than 2.12 can have bad interactions with NullAway; see [here](https://github.com/uber/NullAway/issues/48#issuecomment-340018409).  Please update to Dagger 2.12 to fix the problem.
70*f50c3066SAndroid Build Coastguard Worker
71*f50c3066SAndroid Build Coastguard Worker#### Lombok
72*f50c3066SAndroid Build Coastguard Worker
73*f50c3066SAndroid Build Coastguard WorkerUnlike other annotation processors above, Lombok modifies the in-memory AST of the code it processes, which is the source of numerous incompatibilities with Error Prone and, consequently, NullAway.
74*f50c3066SAndroid Build Coastguard Worker
75*f50c3066SAndroid Build Coastguard WorkerWe do not particularly recommend using NullAway with Lombok. However, NullAway encodes some knowledge of common Lombok annotations and we do try for best-effort compatibility. In particular, common usages like `@lombok.Builder` and `@Data` classes should be supported.
76*f50c3066SAndroid Build Coastguard Worker
77*f50c3066SAndroid Build Coastguard WorkerIn order for NullAway to successfully detect Lombok generated code within the in-memory Java AST, the following configuration option must be passed to Lombok as part of an applicable `lombok.config` file:
78*f50c3066SAndroid Build Coastguard Worker
79*f50c3066SAndroid Build Coastguard Worker```
80*f50c3066SAndroid Build Coastguard WorkeraddLombokGeneratedAnnotation
81*f50c3066SAndroid Build Coastguard Worker```
82*f50c3066SAndroid Build Coastguard Worker
83*f50c3066SAndroid Build Coastguard WorkerThis causes Lombok to add `@lombok.Generated` to the methods/classes it generates. NullAway will ignore (i.e. not check) the implementation of this generated code, treating it as unannotated.
84*f50c3066SAndroid Build Coastguard Worker
85*f50c3066SAndroid Build Coastguard Worker## Code Example
86*f50c3066SAndroid Build Coastguard Worker
87*f50c3066SAndroid Build Coastguard WorkerLet's see how NullAway works on a simple code example:
88*f50c3066SAndroid Build Coastguard Worker```java
89*f50c3066SAndroid Build Coastguard Workerstatic void log(Object x) {
90*f50c3066SAndroid Build Coastguard Worker    System.out.println(x.toString());
91*f50c3066SAndroid Build Coastguard Worker}
92*f50c3066SAndroid Build Coastguard Workerstatic void foo() {
93*f50c3066SAndroid Build Coastguard Worker    log(null);
94*f50c3066SAndroid Build Coastguard Worker}
95*f50c3066SAndroid Build Coastguard Worker```
96*f50c3066SAndroid Build Coastguard WorkerThis code is buggy: when `foo()` is called, the subsequent call to `log()` will fail with an NPE.  You can see this error in the NullAway sample app by running:
97*f50c3066SAndroid Build Coastguard Worker```bash
98*f50c3066SAndroid Build Coastguard Workercp sample/src/main/java/com/uber/mylib/MyClass.java.buggy sample/src/main/java/com/uber/mylib/MyClass.java
99*f50c3066SAndroid Build Coastguard Worker./gradlew build
100*f50c3066SAndroid Build Coastguard Worker```
101*f50c3066SAndroid Build Coastguard Worker
102*f50c3066SAndroid Build Coastguard WorkerBy default, NullAway assumes every method parameter, return value, and field is _non-null_, i.e., it can never be assigned a `null` value.  In the above code, the `x` parameter of `log()` is assumed to be non-null.  So, NullAway reports the following error:
103*f50c3066SAndroid Build Coastguard Worker```
104*f50c3066SAndroid Build Coastguard Workerwarning: [NullAway] passing @Nullable parameter 'null' where @NonNull is required
105*f50c3066SAndroid Build Coastguard Worker    log(null);
106*f50c3066SAndroid Build Coastguard Worker        ^
107*f50c3066SAndroid Build Coastguard Worker```
108*f50c3066SAndroid Build Coastguard WorkerWe can fix this error by allowing `null` to be passed to `log()`, with a `@Nullable` annotation:
109*f50c3066SAndroid Build Coastguard Worker```java
110*f50c3066SAndroid Build Coastguard Workerstatic void log(@Nullable Object x) {
111*f50c3066SAndroid Build Coastguard Worker    System.out.println(x.toString());
112*f50c3066SAndroid Build Coastguard Worker}
113*f50c3066SAndroid Build Coastguard Worker```
114*f50c3066SAndroid Build Coastguard WorkerWith this annotation, NullAway points out the possible null dereference:
115*f50c3066SAndroid Build Coastguard Worker```
116*f50c3066SAndroid Build Coastguard Workerwarning: [NullAway] dereferenced expression x is @Nullable
117*f50c3066SAndroid Build Coastguard Worker    System.out.println(x.toString());
118*f50c3066SAndroid Build Coastguard Worker                        ^
119*f50c3066SAndroid Build Coastguard Worker```
120*f50c3066SAndroid Build Coastguard WorkerWe can fix this warning by adding a null check:
121*f50c3066SAndroid Build Coastguard Worker```java
122*f50c3066SAndroid Build Coastguard Workerstatic void log(@Nullable Object x) {
123*f50c3066SAndroid Build Coastguard Worker    if (x != null) {
124*f50c3066SAndroid Build Coastguard Worker        System.out.println(x.toString());
125*f50c3066SAndroid Build Coastguard Worker    }
126*f50c3066SAndroid Build Coastguard Worker}
127*f50c3066SAndroid Build Coastguard Worker```
128*f50c3066SAndroid Build Coastguard WorkerWith this change, all the NullAway warnings are fixed.
129*f50c3066SAndroid Build Coastguard Worker
130*f50c3066SAndroid Build Coastguard WorkerFor more details on NullAway's checks, error messages, and limitations, see [our detailed guide](https://github.com/uber/NullAway/wiki).
131*f50c3066SAndroid Build Coastguard Worker
132*f50c3066SAndroid Build Coastguard Worker## Support
133*f50c3066SAndroid Build Coastguard Worker
134*f50c3066SAndroid Build Coastguard WorkerPlease feel free to [open a GitHub issue](https://github.com/uber/NullAway/issues) if you have any questions on how to use NullAway.  Or, you can [join the NullAway Discord server](https://discord.gg/QH2F779) and ask us a question there.
135*f50c3066SAndroid Build Coastguard Worker
136*f50c3066SAndroid Build Coastguard Worker## Contributors
137*f50c3066SAndroid Build Coastguard Worker
138*f50c3066SAndroid Build Coastguard WorkerWe'd love for you to contribute to NullAway!  Please note that once
139*f50c3066SAndroid Build Coastguard Workeryou create a pull request, you will be asked to sign our [Uber Contributor License Agreement](https://docs.google.com/a/uber.com/forms/d/1pAwS_-dA1KhPlfxzYLBqK6rsSWwRwH95OCCZrcsY5rk/viewform).
140*f50c3066SAndroid Build Coastguard Worker
141*f50c3066SAndroid Build Coastguard Worker## License
142*f50c3066SAndroid Build Coastguard Worker
143*f50c3066SAndroid Build Coastguard WorkerNullAway is licensed under the MIT license.  See the LICENSE.txt file for more information.
144*f50c3066SAndroid Build Coastguard Worker
145*f50c3066SAndroid Build Coastguard Worker [snapshots]: https://oss.sonatype.org/content/repositories/snapshots/com/uber/nullaway/
146