1*49cdfc7eSAndroid Build Coastguard Worker // SPDX-License-Identifier: GPL-2.0-or-later
2*49cdfc7eSAndroid Build Coastguard Worker /*
3*49cdfc7eSAndroid Build Coastguard Worker * Copyright (c) 2017 Google, Inc.
4*49cdfc7eSAndroid Build Coastguard Worker * Copyright (c) Linux Test Project, 2017-2024
5*49cdfc7eSAndroid Build Coastguard Worker */
6*49cdfc7eSAndroid Build Coastguard Worker
7*49cdfc7eSAndroid Build Coastguard Worker /*\
8*49cdfc7eSAndroid Build Coastguard Worker * [Description]
9*49cdfc7eSAndroid Build Coastguard Worker *
10*49cdfc7eSAndroid Build Coastguard Worker * Regression test for commit:
11*49cdfc7eSAndroid Build Coastguard Worker *
12*49cdfc7eSAndroid Build Coastguard Worker * e645016abc80 ("KEYS: fix writing past end of user-supplied buffer in keyring_read()")
13*49cdfc7eSAndroid Build Coastguard Worker *
14*49cdfc7eSAndroid Build Coastguard Worker * as well as its follow-on fix:
15*49cdfc7eSAndroid Build Coastguard Worker *
16*49cdfc7eSAndroid Build Coastguard Worker * commit 3239b6f29bdf ("KEYS: return full count in keyring_read() if buffer is too small")
17*49cdfc7eSAndroid Build Coastguard Worker */
18*49cdfc7eSAndroid Build Coastguard Worker
19*49cdfc7eSAndroid Build Coastguard Worker #include <errno.h>
20*49cdfc7eSAndroid Build Coastguard Worker
21*49cdfc7eSAndroid Build Coastguard Worker #include "tst_test.h"
22*49cdfc7eSAndroid Build Coastguard Worker #include "lapi/keyctl.h"
23*49cdfc7eSAndroid Build Coastguard Worker
add_test_key(const char * description)24*49cdfc7eSAndroid Build Coastguard Worker static void add_test_key(const char *description)
25*49cdfc7eSAndroid Build Coastguard Worker {
26*49cdfc7eSAndroid Build Coastguard Worker TEST(add_key("user", description, "payload", 7,
27*49cdfc7eSAndroid Build Coastguard Worker KEY_SPEC_PROCESS_KEYRING));
28*49cdfc7eSAndroid Build Coastguard Worker if (TST_RET < 0)
29*49cdfc7eSAndroid Build Coastguard Worker tst_brk(TBROK | TTERRNO, "Failed to add test key");
30*49cdfc7eSAndroid Build Coastguard Worker }
31*49cdfc7eSAndroid Build Coastguard Worker
do_test(void)32*49cdfc7eSAndroid Build Coastguard Worker static void do_test(void)
33*49cdfc7eSAndroid Build Coastguard Worker {
34*49cdfc7eSAndroid Build Coastguard Worker key_serial_t key_ids[2];
35*49cdfc7eSAndroid Build Coastguard Worker
36*49cdfc7eSAndroid Build Coastguard Worker add_test_key("key1");
37*49cdfc7eSAndroid Build Coastguard Worker add_test_key("key2");
38*49cdfc7eSAndroid Build Coastguard Worker
39*49cdfc7eSAndroid Build Coastguard Worker memset(key_ids, 0, sizeof(key_ids));
40*49cdfc7eSAndroid Build Coastguard Worker TEST(keyctl(KEYCTL_READ, KEY_SPEC_PROCESS_KEYRING,
41*49cdfc7eSAndroid Build Coastguard Worker (char *)key_ids, sizeof(key_serial_t)));
42*49cdfc7eSAndroid Build Coastguard Worker if (TST_RET < 0)
43*49cdfc7eSAndroid Build Coastguard Worker tst_brk(TBROK | TTERRNO, "KEYCTL_READ failed");
44*49cdfc7eSAndroid Build Coastguard Worker
45*49cdfc7eSAndroid Build Coastguard Worker /*
46*49cdfc7eSAndroid Build Coastguard Worker * Do not check key_ids[0], as the contents of the buffer are
47*49cdfc7eSAndroid Build Coastguard Worker * unspecified if it was too small. However, key_ids[1] must not have
48*49cdfc7eSAndroid Build Coastguard Worker * been written to, as it was outside the buffer.
49*49cdfc7eSAndroid Build Coastguard Worker */
50*49cdfc7eSAndroid Build Coastguard Worker
51*49cdfc7eSAndroid Build Coastguard Worker if (key_ids[1] != 0)
52*49cdfc7eSAndroid Build Coastguard Worker tst_brk(TFAIL, "KEYCTL_READ overran the buffer");
53*49cdfc7eSAndroid Build Coastguard Worker
54*49cdfc7eSAndroid Build Coastguard Worker if (TST_RET != sizeof(key_ids)) {
55*49cdfc7eSAndroid Build Coastguard Worker tst_brk(TFAIL, "KEYCTL_READ returned %ld but expected %zu",
56*49cdfc7eSAndroid Build Coastguard Worker TST_RET, sizeof(key_ids));
57*49cdfc7eSAndroid Build Coastguard Worker }
58*49cdfc7eSAndroid Build Coastguard Worker
59*49cdfc7eSAndroid Build Coastguard Worker tst_res(TPASS,
60*49cdfc7eSAndroid Build Coastguard Worker "KEYCTL_READ returned full count but didn't overrun the buffer");
61*49cdfc7eSAndroid Build Coastguard Worker }
62*49cdfc7eSAndroid Build Coastguard Worker
63*49cdfc7eSAndroid Build Coastguard Worker static struct tst_test test = {
64*49cdfc7eSAndroid Build Coastguard Worker .test_all = do_test,
65*49cdfc7eSAndroid Build Coastguard Worker .tags = (const struct tst_tag[]) {
66*49cdfc7eSAndroid Build Coastguard Worker {"linux-git", "e645016abc80"},
67*49cdfc7eSAndroid Build Coastguard Worker {"linux-git", "3239b6f29bdf"},
68*49cdfc7eSAndroid Build Coastguard Worker {}
69*49cdfc7eSAndroid Build Coastguard Worker }
70*49cdfc7eSAndroid Build Coastguard Worker };
71