1*635a8641SAndroid Build Coastguard WorkerFrom 91fe99136cd57a8eab9c076e4e1699767bcac3fa Mon Sep 17 00:00:00 2001
2*635a8641SAndroid Build Coastguard WorkerFrom: Hans Wennborg <[email protected]>
3*635a8641SAndroid Build Coastguard WorkerDate: Tue, 2 Oct 2018 16:25:34 +0000
4*635a8641SAndroid Build Coastguard WorkerSubject: [PATCH] Fix -Wdefaulted-function-deleted warning in
5*635a8641SAndroid Build Coastguard Worker MessageLoopCurrent
6*635a8641SAndroid Build Coastguard Worker
7*635a8641SAndroid Build Coastguard WorkerThe new Clang warning points out that the class can't be copy
8*635a8641SAndroid Build Coastguard Workerassigned because the current_ member is const. Copy or move
9*635a8641SAndroid Build Coastguard Workerconstructing it is fine though, and that's all that's needed.
10*635a8641SAndroid Build Coastguard Worker
11*635a8641SAndroid Build Coastguard WorkerBug: 890307
12*635a8641SAndroid Build Coastguard WorkerChange-Id: I3f4d5e69485b84166ba4dd2356cc7973a5e58da6
13*635a8641SAndroid Build Coastguard WorkerReviewed-on: https://chromium-review.googlesource.com/1255613
14*635a8641SAndroid Build Coastguard WorkerReviewed-by: Daniel Cheng <[email protected]>
15*635a8641SAndroid Build Coastguard WorkerCr-Commit-Position: refs/heads/master@{#595867}
16*635a8641SAndroid Build Coastguard Worker---
17*635a8641SAndroid Build Coastguard Worker base/message_loop/message_loop_current.h | 4 ++--
18*635a8641SAndroid Build Coastguard Worker 1 file changed, 2 insertions(+), 2 deletions(-)
19*635a8641SAndroid Build Coastguard Worker
20*635a8641SAndroid Build Coastguard Workerdiff --git a/base/message_loop/message_loop_current.h b/base/message_loop/message_loop_current.h
21*635a8641SAndroid Build Coastguard Workerindex d623cbc7f7b2..403d0dcc2ddb 100644
22*635a8641SAndroid Build Coastguard Worker--- a/base/message_loop/message_loop_current.h
23*635a8641SAndroid Build Coastguard Worker+++ b/base/message_loop/message_loop_current.h
24*635a8641SAndroid Build Coastguard Worker@@ -38,9 +38,9 @@ class MessageLoop;
25*635a8641SAndroid Build Coastguard Worker class BASE_EXPORT MessageLoopCurrent {
26*635a8641SAndroid Build Coastguard Worker  public:
27*635a8641SAndroid Build Coastguard Worker   // MessageLoopCurrent is effectively just a disguised pointer and is fine to
28*635a8641SAndroid Build Coastguard Worker-  // copy around.
29*635a8641SAndroid Build Coastguard Worker+  // copy/move around.
30*635a8641SAndroid Build Coastguard Worker   MessageLoopCurrent(const MessageLoopCurrent& other) = default;
31*635a8641SAndroid Build Coastguard Worker-  MessageLoopCurrent& operator=(const MessageLoopCurrent& other) = default;
32*635a8641SAndroid Build Coastguard Worker+  MessageLoopCurrent(MessageLoopCurrent&& other) = default;
33*635a8641SAndroid Build Coastguard Worker
34*635a8641SAndroid Build Coastguard Worker   // Returns a proxy object to interact with the MessageLoop running the
35*635a8641SAndroid Build Coastguard Worker   // current thread. It must only be used on the thread it was obtained.
36*635a8641SAndroid Build Coastguard Worker--
37*635a8641SAndroid Build Coastguard Worker2.22.0.rc2.383.gf4fbbf30c2-goog
38*635a8641SAndroid Build Coastguard Worker
39