1*33edd672SMarkcommit 0cb6965869ab94858d9b843ab5d94f7deaea5dc8 2*33edd672SMarkAuthor: Fabian Meumertzheim <[email protected]> 3*33edd672SMarkDate: Mon Jun 12 16:12:02 2023 +0200 4*33edd672SMark 5*33edd672SMark Disable layering_check 6*33edd672SMark 7*33edd672SMark protobuf misses a sizeable number of dependency declarations, which 8*33edd672SMark means that `layering_check` has to be disabled for it. 9*33edd672SMark 10*33edd672SMark Generated with: 11*33edd672SMark ``` 12*33edd672SMark buildozer 'add features -layering_check' //src/...:__pkg__ 13*33edd672SMark ``` 14*33edd672SMark 15*33edd672SMark Contains only the changes to `package` directives. 16*33edd672SMark 17*33edd672SMarkdiff --git src/BUILD.bazel src/BUILD.bazel 18*33edd672SMarkindex 0de1a4eb1..b7e405147 100644 19*33edd672SMark--- src/BUILD.bazel 20*33edd672SMark+++ src/BUILD.bazel 21*33edd672SMark@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_filegroup", "pkg_files", "strip_prefix") 22*33edd672SMark load("@upb//cmake:build_defs.bzl", "staleness_test") 23*33edd672SMark load("//conformance:defs.bzl", "conformance_test") 24*33edd672SMark 25*33edd672SMark+package(features = ["-layering_check"]) 26*33edd672SMark+ 27*33edd672SMark pkg_files( 28*33edd672SMark name = "dist_files", 29*33edd672SMark srcs = glob(["**"]), 30*33edd672SMarkdiff --git src/google/protobuf/BUILD.bazel src/google/protobuf/BUILD.bazel 31*33edd672SMarkindex 77ed2309f..8c38fb872 100644 32*33edd672SMark--- src/google/protobuf/BUILD.bazel 33*33edd672SMark+++ src/google/protobuf/BUILD.bazel 34*33edd672SMark@@ -13,6 +13,7 @@ package( 35*33edd672SMark "//:__pkg__", # "public" targets are alias rules in //. 36*33edd672SMark "//json:__subpackages__", 37*33edd672SMark ], 38*33edd672SMark+ features = ["-layering_check"], 39*33edd672SMark ) 40*33edd672SMark 41*33edd672SMark proto_library( 42*33edd672SMarkdiff --git src/google/protobuf/compiler/BUILD.bazel src/google/protobuf/compiler/BUILD.bazel 43*33edd672SMarkindex a2171c806..8dcd34667 100644 44*33edd672SMark--- src/google/protobuf/compiler/BUILD.bazel 45*33edd672SMark+++ src/google/protobuf/compiler/BUILD.bazel 46*33edd672SMark@@ -13,6 +13,8 @@ load("@rules_proto//proto:defs.bzl", "proto_library") 47*33edd672SMark load("//build_defs:arch_tests.bzl", "aarch64_test", "x86_64_test") 48*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS") 49*33edd672SMark 50*33edd672SMark+package(features = ["-layering_check"]) 51*33edd672SMark+ 52*33edd672SMark proto_library( 53*33edd672SMark name = "plugin_proto", 54*33edd672SMark srcs = ["plugin.proto"], 55*33edd672SMarkdiff --git src/google/protobuf/compiler/allowlists/BUILD.bazel src/google/protobuf/compiler/allowlists/BUILD.bazel 56*33edd672SMarkindex 569a142fc..0a90b312f 100644 57*33edd672SMark--- src/google/protobuf/compiler/allowlists/BUILD.bazel 58*33edd672SMark+++ src/google/protobuf/compiler/allowlists/BUILD.bazel 59*33edd672SMark@@ -1,7 +1,10 @@ 60*33edd672SMark load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 61*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 62*33edd672SMark 63*33edd672SMark-package(default_visibility = ["//visibility:private"]) 64*33edd672SMark+package( 65*33edd672SMark+ default_visibility = ["//visibility:private"], 66*33edd672SMark+ features = ["-layering_check"], 67*33edd672SMark+) 68*33edd672SMark 69*33edd672SMark cc_library( 70*33edd672SMark name = "allowlist", 71*33edd672SMarkdiff --git src/google/protobuf/compiler/cpp/BUILD.bazel src/google/protobuf/compiler/cpp/BUILD.bazel 72*33edd672SMarkindex ac1184d32..deacbf582 100644 73*33edd672SMark--- src/google/protobuf/compiler/cpp/BUILD.bazel 74*33edd672SMark+++ src/google/protobuf/compiler/cpp/BUILD.bazel 75*33edd672SMark@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 76*33edd672SMark load("@rules_proto//proto:defs.bzl", "proto_library") 77*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 78*33edd672SMark 79*33edd672SMark+package(features = ["-layering_check"]) 80*33edd672SMark+ 81*33edd672SMark cc_library( 82*33edd672SMark name = "names", 83*33edd672SMark hdrs = ["names.h"], 84*33edd672SMarkdiff --git src/google/protobuf/compiler/csharp/BUILD.bazel src/google/protobuf/compiler/csharp/BUILD.bazel 85*33edd672SMarkindex 96b8dcbc0..a2d549f26 100644 86*33edd672SMark--- src/google/protobuf/compiler/csharp/BUILD.bazel 87*33edd672SMark+++ src/google/protobuf/compiler/csharp/BUILD.bazel 88*33edd672SMark@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 89*33edd672SMark load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 90*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 91*33edd672SMark 92*33edd672SMark+package(features = ["-layering_check"]) 93*33edd672SMark+ 94*33edd672SMark cc_library( 95*33edd672SMark name = "names", 96*33edd672SMark hdrs = ["names.h"], 97*33edd672SMarkdiff --git src/google/protobuf/compiler/java/BUILD.bazel src/google/protobuf/compiler/java/BUILD.bazel 98*33edd672SMarkindex 94573892c..c94f472d6 100644 99*33edd672SMark--- src/google/protobuf/compiler/java/BUILD.bazel 100*33edd672SMark+++ src/google/protobuf/compiler/java/BUILD.bazel 101*33edd672SMark@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 102*33edd672SMark load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 103*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 104*33edd672SMark 105*33edd672SMark+package(features = ["-layering_check"]) 106*33edd672SMark+ 107*33edd672SMark cc_library( 108*33edd672SMark name = "names", 109*33edd672SMark hdrs = ["names.h"], 110*33edd672SMarkdiff --git src/google/protobuf/compiler/objectivec/BUILD.bazel src/google/protobuf/compiler/objectivec/BUILD.bazel 111*33edd672SMarkindex f78990394..6c534219a 100644 112*33edd672SMark--- src/google/protobuf/compiler/objectivec/BUILD.bazel 113*33edd672SMark+++ src/google/protobuf/compiler/objectivec/BUILD.bazel 114*33edd672SMark@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 115*33edd672SMark load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 116*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 117*33edd672SMark 118*33edd672SMark+package(features = ["-layering_check"]) 119*33edd672SMark+ 120*33edd672SMark cc_library( 121*33edd672SMark name = "names", 122*33edd672SMark hdrs = ["names.h"], 123*33edd672SMarkdiff --git src/google/protobuf/compiler/php/BUILD.bazel src/google/protobuf/compiler/php/BUILD.bazel 124*33edd672SMarkindex fe9e75c2c..a569a1c9d 100644 125*33edd672SMark--- src/google/protobuf/compiler/php/BUILD.bazel 126*33edd672SMark+++ src/google/protobuf/compiler/php/BUILD.bazel 127*33edd672SMark@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library") 128*33edd672SMark load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 129*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 130*33edd672SMark 131*33edd672SMark+package(features = ["-layering_check"]) 132*33edd672SMark+ 133*33edd672SMark cc_library( 134*33edd672SMark name = "names", 135*33edd672SMark hdrs = ["names.h"], 136*33edd672SMarkdiff --git src/google/protobuf/compiler/python/BUILD.bazel src/google/protobuf/compiler/python/BUILD.bazel 137*33edd672SMarkindex 5d26e0ce9..ce017acf1 100644 138*33edd672SMark--- src/google/protobuf/compiler/python/BUILD.bazel 139*33edd672SMark+++ src/google/protobuf/compiler/python/BUILD.bazel 140*33edd672SMark@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 141*33edd672SMark load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 142*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 143*33edd672SMark 144*33edd672SMark+package(features = ["-layering_check"]) 145*33edd672SMark+ 146*33edd672SMark cc_library( 147*33edd672SMark name = "python", 148*33edd672SMark srcs = [ 149*33edd672SMarkdiff --git src/google/protobuf/compiler/ruby/BUILD.bazel src/google/protobuf/compiler/ruby/BUILD.bazel 150*33edd672SMarkindex 520b69194..1e437e7bc 100644 151*33edd672SMark--- src/google/protobuf/compiler/ruby/BUILD.bazel 152*33edd672SMark+++ src/google/protobuf/compiler/ruby/BUILD.bazel 153*33edd672SMark@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 154*33edd672SMark load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 155*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 156*33edd672SMark 157*33edd672SMark+package(features = ["-layering_check"]) 158*33edd672SMark+ 159*33edd672SMark cc_library( 160*33edd672SMark name = "ruby", 161*33edd672SMark srcs = ["ruby_generator.cc"], 162*33edd672SMarkdiff --git src/google/protobuf/compiler/rust/BUILD.bazel src/google/protobuf/compiler/rust/BUILD.bazel 163*33edd672SMarkindex 7c1f5b856..4a10038d1 100644 164*33edd672SMark--- src/google/protobuf/compiler/rust/BUILD.bazel 165*33edd672SMark+++ src/google/protobuf/compiler/rust/BUILD.bazel 166*33edd672SMark@@ -5,6 +5,8 @@ 167*33edd672SMark load("@rules_cc//cc:defs.bzl", "cc_library") 168*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 169*33edd672SMark 170*33edd672SMark+package(features = ["-layering_check"]) 171*33edd672SMark+ 172*33edd672SMark cc_library( 173*33edd672SMark name = "rust", 174*33edd672SMark srcs = ["generator.cc"], 175*33edd672SMarkdiff --git src/google/protobuf/io/BUILD.bazel src/google/protobuf/io/BUILD.bazel 176*33edd672SMarkindex 8f39625c2..fc2f8e002 100644 177*33edd672SMark--- src/google/protobuf/io/BUILD.bazel 178*33edd672SMark+++ src/google/protobuf/io/BUILD.bazel 179*33edd672SMark@@ -6,6 +6,7 @@ load("//build_defs:cpp_opts.bzl", "COPTS") 180*33edd672SMark 181*33edd672SMark package( 182*33edd672SMark default_visibility = ["//visibility:public"], 183*33edd672SMark+ features = ["-layering_check"], 184*33edd672SMark ) 185*33edd672SMark 186*33edd672SMark cc_library( 187*33edd672SMarkdiff --git src/google/protobuf/json/BUILD.bazel src/google/protobuf/json/BUILD.bazel 188*33edd672SMarkindex d6019f939..83caca985 100644 189*33edd672SMark--- src/google/protobuf/json/BUILD.bazel 190*33edd672SMark+++ src/google/protobuf/json/BUILD.bazel 191*33edd672SMark@@ -1,10 +1,13 @@ 192*33edd672SMark load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 193*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 194*33edd672SMark 195*33edd672SMark-package(default_visibility = [ 196*33edd672SMark- "//pkg:__pkg__", 197*33edd672SMark- "//src/google/protobuf/json:__pkg__", 198*33edd672SMark-]) 199*33edd672SMark+package( 200*33edd672SMark+ default_visibility = [ 201*33edd672SMark+ "//pkg:__pkg__", 202*33edd672SMark+ "//src/google/protobuf/json:__pkg__", 203*33edd672SMark+ ], 204*33edd672SMark+ features = ["-layering_check"], 205*33edd672SMark+) 206*33edd672SMark 207*33edd672SMark licenses(["notice"]) 208*33edd672SMark 209*33edd672SMarkdiff --git src/google/protobuf/stubs/BUILD.bazel src/google/protobuf/stubs/BUILD.bazel 210*33edd672SMarkindex c8fc3e9d0..9521f5103 100644 211*33edd672SMark--- src/google/protobuf/stubs/BUILD.bazel 212*33edd672SMark+++ src/google/protobuf/stubs/BUILD.bazel 213*33edd672SMark@@ -7,6 +7,7 @@ load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS") 214*33edd672SMark 215*33edd672SMark package( 216*33edd672SMark default_visibility = ["//:__subpackages__"], 217*33edd672SMark+ features = ["-layering_check"], 218*33edd672SMark ) 219*33edd672SMark 220*33edd672SMark cc_library( 221*33edd672SMarkdiff --git src/google/protobuf/testing/BUILD.bazel src/google/protobuf/testing/BUILD.bazel 222*33edd672SMarkindex 572c1f9f4..d10435cce 100644 223*33edd672SMark--- src/google/protobuf/testing/BUILD.bazel 224*33edd672SMark+++ src/google/protobuf/testing/BUILD.bazel 225*33edd672SMark@@ -5,7 +5,10 @@ load("@rules_cc//cc:defs.bzl", "cc_library") 226*33edd672SMark load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 227*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS") 228*33edd672SMark 229*33edd672SMark-package(default_visibility = ["//:__subpackages__"]) 230*33edd672SMark+package( 231*33edd672SMark+ default_visibility = ["//:__subpackages__"], 232*33edd672SMark+ features = ["-layering_check"], 233*33edd672SMark+) 234*33edd672SMark 235*33edd672SMark cc_library( 236*33edd672SMark name = "testing", 237*33edd672SMarkdiff --git src/google/protobuf/util/BUILD.bazel src/google/protobuf/util/BUILD.bazel 238*33edd672SMarkindex 3afe464cf..03a3045b3 100644 239*33edd672SMark--- src/google/protobuf/util/BUILD.bazel 240*33edd672SMark+++ src/google/protobuf/util/BUILD.bazel 241*33edd672SMark@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 242*33edd672SMark load("@rules_proto//proto:defs.bzl", "proto_library") 243*33edd672SMark load("//build_defs:cpp_opts.bzl", "COPTS") 244*33edd672SMark 245*33edd672SMark+package(features = ["-layering_check"]) 246*33edd672SMark+ 247*33edd672SMark cc_library( 248*33edd672SMark name = "delimited_message_util", 249*33edd672SMark srcs = ["delimited_message_util.cc"], 250