1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "modules/pacing/packet_router.h"
12
13 #include <cstddef>
14 #include <cstdint>
15 #include <memory>
16 #include <utility>
17
18 #include "api/units/time_delta.h"
19 #include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20 #include "modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
21 #include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
22 #include "rtc_base/checks.h"
23 #include "rtc_base/fake_clock.h"
24 #include "test/gmock.h"
25 #include "test/gtest.h"
26
27 namespace webrtc {
28
29 // TODO(eladalon): Restructure and/or replace the existing monolithic tests
30 // (only some of the test are monolithic) according to the new
31 // guidelines - small tests for one thing at a time.
32 // (I'm not removing any tests during CL, so as to demonstrate no regressions.)
33
34 namespace {
35
36 using ::testing::_;
37 using ::testing::AnyNumber;
38 using ::testing::AtLeast;
39 using ::testing::ElementsAreArray;
40 using ::testing::Field;
41 using ::testing::Gt;
42 using ::testing::Le;
43 using ::testing::NiceMock;
44 using ::testing::Property;
45 using ::testing::Return;
46 using ::testing::SaveArg;
47
48 constexpr int kProbeMinProbes = 5;
49 constexpr int kProbeMinBytes = 1000;
50
51 } // namespace
52
53 class PacketRouterTest : public ::testing::Test {
54 public:
PacketRouterTest()55 PacketRouterTest() {
56 extension_manager.Register<TransportSequenceNumber>(/*id=*/1);
57 }
58
59 protected:
BuildRtpPacket(uint32_t ssrc)60 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(uint32_t ssrc) {
61 std::unique_ptr<RtpPacketToSend> packet =
62 std::make_unique<RtpPacketToSend>(&extension_manager);
63 packet->SetSsrc(ssrc);
64 return packet;
65 }
66
67 PacketRouter packet_router_;
68 RtpHeaderExtensionMap extension_manager;
69 };
70
TEST_F(PacketRouterTest,Sanity_NoModuleRegistered_GeneratePadding)71 TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_GeneratePadding) {
72 constexpr DataSize bytes = DataSize::Bytes(300);
73 const PacedPacketInfo paced_info(1, kProbeMinProbes, kProbeMinBytes);
74
75 EXPECT_TRUE(packet_router_.GeneratePadding(bytes).empty());
76 }
77
78
TEST_F(PacketRouterTest,Sanity_NoModuleRegistered_SendRemb)79 TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_SendRemb) {
80 const std::vector<uint32_t> ssrcs = {1, 2, 3};
81 constexpr uint32_t bitrate_bps = 10000;
82 // Expect not to crash
83 packet_router_.SendRemb(bitrate_bps, ssrcs);
84 }
85
TEST_F(PacketRouterTest,Sanity_NoModuleRegistered_SendTransportFeedback)86 TEST_F(PacketRouterTest, Sanity_NoModuleRegistered_SendTransportFeedback) {
87 std::vector<std::unique_ptr<rtcp::RtcpPacket>> feedback;
88 feedback.push_back(std::make_unique<rtcp::TransportFeedback>());
89 // Expect not to crash
90 packet_router_.SendCombinedRtcpPacket(std::move(feedback));
91 }
92
TEST_F(PacketRouterTest,GeneratePaddingPrioritizesRtx)93 TEST_F(PacketRouterTest, GeneratePaddingPrioritizesRtx) {
94 // Two RTP modules. The first (prioritized due to rtx) isn't sending media so
95 // should not be called.
96 const uint16_t kSsrc1 = 1234;
97 const uint16_t kSsrc2 = 4567;
98
99 NiceMock<MockRtpRtcpInterface> rtp_1;
100 ON_CALL(rtp_1, RtxSendStatus()).WillByDefault(Return(kRtxRedundantPayloads));
101 ON_CALL(rtp_1, SSRC()).WillByDefault(Return(kSsrc1));
102 ON_CALL(rtp_1, SupportsPadding).WillByDefault(Return(false));
103
104 NiceMock<MockRtpRtcpInterface> rtp_2;
105 ON_CALL(rtp_2, RtxSendStatus()).WillByDefault(Return(kRtxOff));
106 ON_CALL(rtp_2, SSRC()).WillByDefault(Return(kSsrc2));
107 ON_CALL(rtp_2, SupportsPadding).WillByDefault(Return(true));
108
109 packet_router_.AddSendRtpModule(&rtp_1, false);
110 packet_router_.AddSendRtpModule(&rtp_2, false);
111
112 const size_t kPaddingSize = 123;
113 const size_t kExpectedPaddingPackets = 1;
114 EXPECT_CALL(rtp_1, GeneratePadding(_)).Times(0);
115 EXPECT_CALL(rtp_2, GeneratePadding(kPaddingSize))
116 .WillOnce([&](size_t padding_size) {
117 return std::vector<std::unique_ptr<RtpPacketToSend>>(
118 kExpectedPaddingPackets);
119 });
120 auto generated_padding =
121 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingSize));
122 EXPECT_EQ(generated_padding.size(), kExpectedPaddingPackets);
123
124 packet_router_.RemoveSendRtpModule(&rtp_1);
125 packet_router_.RemoveSendRtpModule(&rtp_2);
126 }
127
TEST_F(PacketRouterTest,GeneratePaddingPrioritizesVideo)128 TEST_F(PacketRouterTest, GeneratePaddingPrioritizesVideo) {
129 // Two RTP modules. Neither support RTX, both support padding,
130 // but the first one is for audio and second for video.
131 const uint16_t kSsrc1 = 1234;
132 const uint16_t kSsrc2 = 4567;
133 const size_t kPaddingSize = 123;
134 const size_t kExpectedPaddingPackets = 1;
135
136 auto generate_padding = [&](size_t padding_size) {
137 return std::vector<std::unique_ptr<RtpPacketToSend>>(
138 kExpectedPaddingPackets);
139 };
140
141 NiceMock<MockRtpRtcpInterface> audio_module;
142 ON_CALL(audio_module, RtxSendStatus()).WillByDefault(Return(kRtxOff));
143 ON_CALL(audio_module, SSRC()).WillByDefault(Return(kSsrc1));
144 ON_CALL(audio_module, SupportsPadding).WillByDefault(Return(true));
145 ON_CALL(audio_module, IsAudioConfigured).WillByDefault(Return(true));
146
147 NiceMock<MockRtpRtcpInterface> video_module;
148 ON_CALL(video_module, RtxSendStatus()).WillByDefault(Return(kRtxOff));
149 ON_CALL(video_module, SSRC()).WillByDefault(Return(kSsrc2));
150 ON_CALL(video_module, SupportsPadding).WillByDefault(Return(true));
151 ON_CALL(video_module, IsAudioConfigured).WillByDefault(Return(false));
152
153 // First add only the audio module. Since this is the only choice we have,
154 // padding should be sent on the audio ssrc.
155 packet_router_.AddSendRtpModule(&audio_module, false);
156 EXPECT_CALL(audio_module, GeneratePadding(kPaddingSize))
157 .WillOnce(generate_padding);
158 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingSize));
159
160 // Add the video module, this should now be prioritized since we cannot
161 // guarantee that audio packets will be included in the BWE.
162 packet_router_.AddSendRtpModule(&video_module, false);
163 EXPECT_CALL(audio_module, GeneratePadding).Times(0);
164 EXPECT_CALL(video_module, GeneratePadding(kPaddingSize))
165 .WillOnce(generate_padding);
166 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingSize));
167
168 // Remove and the add audio module again. Module order shouldn't matter;
169 // video should still be prioritized.
170 packet_router_.RemoveSendRtpModule(&audio_module);
171 packet_router_.AddSendRtpModule(&audio_module, false);
172 EXPECT_CALL(audio_module, GeneratePadding).Times(0);
173 EXPECT_CALL(video_module, GeneratePadding(kPaddingSize))
174 .WillOnce(generate_padding);
175 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingSize));
176
177 // Remove and the video module, we should fall back to padding on the
178 // audio module again.
179 packet_router_.RemoveSendRtpModule(&video_module);
180 EXPECT_CALL(audio_module, GeneratePadding(kPaddingSize))
181 .WillOnce(generate_padding);
182 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingSize));
183
184 packet_router_.RemoveSendRtpModule(&audio_module);
185 }
186
TEST_F(PacketRouterTest,PadsOnLastActiveMediaStream)187 TEST_F(PacketRouterTest, PadsOnLastActiveMediaStream) {
188 const uint16_t kSsrc1 = 1234;
189 const uint16_t kSsrc2 = 4567;
190 const uint16_t kSsrc3 = 8901;
191
192 // First two rtp modules send media and have rtx.
193 NiceMock<MockRtpRtcpInterface> rtp_1;
194 EXPECT_CALL(rtp_1, SSRC()).WillRepeatedly(Return(kSsrc1));
195 EXPECT_CALL(rtp_1, SupportsPadding).WillRepeatedly(Return(true));
196 EXPECT_CALL(rtp_1, SupportsRtxPayloadPadding).WillRepeatedly(Return(true));
197 EXPECT_CALL(rtp_1, TrySendPacket).WillRepeatedly(Return(false));
198 EXPECT_CALL(
199 rtp_1,
200 TrySendPacket(
201 ::testing::Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc1)), _))
202 .WillRepeatedly(Return(true));
203
204 NiceMock<MockRtpRtcpInterface> rtp_2;
205 EXPECT_CALL(rtp_2, SSRC()).WillRepeatedly(Return(kSsrc2));
206 EXPECT_CALL(rtp_2, SupportsPadding).WillRepeatedly(Return(true));
207 EXPECT_CALL(rtp_2, SupportsRtxPayloadPadding).WillRepeatedly(Return(true));
208 EXPECT_CALL(rtp_2, TrySendPacket).WillRepeatedly(Return(false));
209 EXPECT_CALL(
210 rtp_2,
211 TrySendPacket(
212 ::testing::Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc2)), _))
213 .WillRepeatedly(Return(true));
214
215 // Third module is sending media, but does not support rtx.
216 NiceMock<MockRtpRtcpInterface> rtp_3;
217 EXPECT_CALL(rtp_3, SSRC()).WillRepeatedly(Return(kSsrc3));
218 EXPECT_CALL(rtp_3, SupportsPadding).WillRepeatedly(Return(true));
219 EXPECT_CALL(rtp_3, SupportsRtxPayloadPadding).WillRepeatedly(Return(false));
220 EXPECT_CALL(rtp_3, TrySendPacket).WillRepeatedly(Return(false));
221 EXPECT_CALL(
222 rtp_3,
223 TrySendPacket(
224 ::testing::Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc3)), _))
225 .WillRepeatedly(Return(true));
226
227 packet_router_.AddSendRtpModule(&rtp_1, false);
228 packet_router_.AddSendRtpModule(&rtp_2, false);
229 packet_router_.AddSendRtpModule(&rtp_3, false);
230
231 const size_t kPaddingBytes = 100;
232
233 // Initially, padding will be sent on last added rtp module that sends media
234 // and supports rtx.
235 EXPECT_CALL(rtp_2, GeneratePadding(kPaddingBytes))
236 .Times(1)
237 .WillOnce([&](size_t target_size_bytes) {
238 std::vector<std::unique_ptr<RtpPacketToSend>> packets;
239 packets.push_back(BuildRtpPacket(kSsrc2));
240 return packets;
241 });
242 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingBytes));
243
244 // Send media on first module. Padding should be sent on that module.
245 packet_router_.SendPacket(BuildRtpPacket(kSsrc1), PacedPacketInfo());
246
247 EXPECT_CALL(rtp_1, GeneratePadding(kPaddingBytes))
248 .Times(1)
249 .WillOnce([&](size_t target_size_bytes) {
250 std::vector<std::unique_ptr<RtpPacketToSend>> packets;
251 packets.push_back(BuildRtpPacket(kSsrc1));
252 return packets;
253 });
254 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingBytes));
255
256 // Send media on second module. Padding should be sent there.
257 packet_router_.SendPacket(BuildRtpPacket(kSsrc2), PacedPacketInfo());
258
259 // If the last active module is removed, and no module sends media before
260 // the next padding request, and arbitrary module will be selected.
261 packet_router_.RemoveSendRtpModule(&rtp_2);
262
263 // Send on and then remove all remaining modules.
264 RtpRtcpInterface* last_send_module;
265 EXPECT_CALL(rtp_1, GeneratePadding(kPaddingBytes))
266 .Times(1)
267 .WillOnce([&](size_t target_size_bytes) {
268 last_send_module = &rtp_1;
269 std::vector<std::unique_ptr<RtpPacketToSend>> packets;
270 packets.push_back(BuildRtpPacket(kSsrc1));
271 return packets;
272 });
273 EXPECT_CALL(rtp_3, GeneratePadding(kPaddingBytes))
274 .Times(1)
275 .WillOnce([&](size_t target_size_bytes) {
276 last_send_module = &rtp_3;
277 std::vector<std::unique_ptr<RtpPacketToSend>> packets;
278 packets.push_back(BuildRtpPacket(kSsrc3));
279 return packets;
280 });
281
282 for (int i = 0; i < 2; ++i) {
283 last_send_module = nullptr;
284 packet_router_.GeneratePadding(DataSize::Bytes(kPaddingBytes));
285 EXPECT_NE(last_send_module, nullptr);
286 packet_router_.RemoveSendRtpModule(last_send_module);
287 }
288 }
289
TEST_F(PacketRouterTest,AllocatesTransportSequenceNumbers)290 TEST_F(PacketRouterTest, AllocatesTransportSequenceNumbers) {
291 const uint16_t kStartSeq = 0xFFF0;
292 const size_t kNumPackets = 32;
293 const uint16_t kSsrc1 = 1234;
294
295 PacketRouter packet_router(kStartSeq - 1);
296 NiceMock<MockRtpRtcpInterface> rtp_1;
297 EXPECT_CALL(rtp_1, SSRC()).WillRepeatedly(Return(kSsrc1));
298 EXPECT_CALL(rtp_1, TrySendPacket).WillRepeatedly(Return(true));
299 packet_router.AddSendRtpModule(&rtp_1, false);
300
301 for (size_t i = 0; i < kNumPackets; ++i) {
302 auto packet = BuildRtpPacket(kSsrc1);
303 EXPECT_TRUE(packet->ReserveExtension<TransportSequenceNumber>());
304 packet_router.SendPacket(std::move(packet), PacedPacketInfo());
305 uint32_t expected_unwrapped_seq = static_cast<uint32_t>(kStartSeq) + i;
306 EXPECT_EQ(static_cast<uint16_t>(expected_unwrapped_seq & 0xFFFF),
307 packet_router.CurrentTransportSequenceNumber());
308 }
309
310 packet_router.RemoveSendRtpModule(&rtp_1);
311 }
312
TEST_F(PacketRouterTest,SendTransportFeedback)313 TEST_F(PacketRouterTest, SendTransportFeedback) {
314 NiceMock<MockRtpRtcpInterface> rtp_1;
315 NiceMock<MockRtpRtcpInterface> rtp_2;
316
317 ON_CALL(rtp_1, RTCP()).WillByDefault(Return(RtcpMode::kCompound));
318 ON_CALL(rtp_2, RTCP()).WillByDefault(Return(RtcpMode::kCompound));
319
320 packet_router_.AddSendRtpModule(&rtp_1, false);
321 packet_router_.AddReceiveRtpModule(&rtp_2, false);
322
323 std::vector<std::unique_ptr<rtcp::RtcpPacket>> feedback;
324 feedback.push_back(std::make_unique<rtcp::TransportFeedback>());
325 EXPECT_CALL(rtp_1, SendCombinedRtcpPacket);
326 packet_router_.SendCombinedRtcpPacket(std::move(feedback));
327 packet_router_.RemoveSendRtpModule(&rtp_1);
328 EXPECT_CALL(rtp_2, SendCombinedRtcpPacket);
329 std::vector<std::unique_ptr<rtcp::RtcpPacket>> new_feedback;
330 new_feedback.push_back(std::make_unique<rtcp::TransportFeedback>());
331 packet_router_.SendCombinedRtcpPacket(std::move(new_feedback));
332 packet_router_.RemoveReceiveRtpModule(&rtp_2);
333 }
334
TEST_F(PacketRouterTest,SendPacketWithoutTransportSequenceNumbers)335 TEST_F(PacketRouterTest, SendPacketWithoutTransportSequenceNumbers) {
336 const uint16_t kSsrc1 = 1234;
337 NiceMock<MockRtpRtcpInterface> rtp_1;
338 ON_CALL(rtp_1, SendingMedia).WillByDefault(Return(true));
339 ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1));
340 packet_router_.AddSendRtpModule(&rtp_1, false);
341
342 // Send a packet without TransportSequenceNumber extension registered,
343 // packets sent should not have the extension set.
344 RtpHeaderExtensionMap extension_manager;
345 auto packet = std::make_unique<RtpPacketToSend>(&extension_manager);
346 packet->SetSsrc(kSsrc1);
347 EXPECT_CALL(
348 rtp_1,
349 TrySendPacket(
350 Property(&RtpPacketToSend::HasExtension<TransportSequenceNumber>,
351 false),
352 _))
353 .WillOnce(Return(true));
354 packet_router_.SendPacket(std::move(packet), PacedPacketInfo());
355
356 packet_router_.RemoveSendRtpModule(&rtp_1);
357 }
358
TEST_F(PacketRouterTest,SendPacketAssignsTransportSequenceNumbers)359 TEST_F(PacketRouterTest, SendPacketAssignsTransportSequenceNumbers) {
360 NiceMock<MockRtpRtcpInterface> rtp_1;
361 NiceMock<MockRtpRtcpInterface> rtp_2;
362
363 const uint16_t kSsrc1 = 1234;
364 const uint16_t kSsrc2 = 2345;
365
366 ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1));
367 ON_CALL(rtp_2, SSRC).WillByDefault(Return(kSsrc2));
368
369 packet_router_.AddSendRtpModule(&rtp_1, false);
370 packet_router_.AddSendRtpModule(&rtp_2, false);
371
372 // Transport sequence numbers start at 1, for historical reasons.
373 uint16_t transport_sequence_number = 1;
374
375 auto packet = BuildRtpPacket(kSsrc1);
376 EXPECT_TRUE(packet->ReserveExtension<TransportSequenceNumber>());
377 EXPECT_CALL(
378 rtp_1,
379 TrySendPacket(
380 Property(&RtpPacketToSend::GetExtension<TransportSequenceNumber>,
381 transport_sequence_number),
382 _))
383 .WillOnce(Return(true));
384 packet_router_.SendPacket(std::move(packet), PacedPacketInfo());
385
386 ++transport_sequence_number;
387 packet = BuildRtpPacket(kSsrc2);
388 EXPECT_TRUE(packet->ReserveExtension<TransportSequenceNumber>());
389
390 EXPECT_CALL(
391 rtp_2,
392 TrySendPacket(
393 Property(&RtpPacketToSend::GetExtension<TransportSequenceNumber>,
394 transport_sequence_number),
395 _))
396 .WillOnce(Return(true));
397 packet_router_.SendPacket(std::move(packet), PacedPacketInfo());
398
399 packet_router_.RemoveSendRtpModule(&rtp_1);
400 packet_router_.RemoveSendRtpModule(&rtp_2);
401 }
402
TEST_F(PacketRouterTest,DoesNotIncrementTransportSequenceNumberOnSendFailure)403 TEST_F(PacketRouterTest, DoesNotIncrementTransportSequenceNumberOnSendFailure) {
404 NiceMock<MockRtpRtcpInterface> rtp;
405 constexpr uint32_t kSsrc = 1234;
406 ON_CALL(rtp, SSRC).WillByDefault(Return(kSsrc));
407 packet_router_.AddSendRtpModule(&rtp, false);
408
409 // Transport sequence numbers start at 1, for historical reasons.
410 const uint16_t kStartTransportSequenceNumber = 1;
411
412 // Build and send a packet - it should be assigned the start sequence number.
413 // Return failure status code to make sure sequence number is not incremented.
414 auto packet = BuildRtpPacket(kSsrc);
415 EXPECT_TRUE(packet->ReserveExtension<TransportSequenceNumber>());
416 EXPECT_CALL(
417 rtp, TrySendPacket(
418 Property(&RtpPacketToSend::GetExtension<TransportSequenceNumber>,
419 kStartTransportSequenceNumber),
420 _))
421 .WillOnce(Return(false));
422 packet_router_.SendPacket(std::move(packet), PacedPacketInfo());
423
424 // Send another packet, verify transport sequence number is still at the
425 // start state.
426 packet = BuildRtpPacket(kSsrc);
427 EXPECT_TRUE(packet->ReserveExtension<TransportSequenceNumber>());
428
429 EXPECT_CALL(
430 rtp, TrySendPacket(
431 Property(&RtpPacketToSend::GetExtension<TransportSequenceNumber>,
432 kStartTransportSequenceNumber),
433 _))
434 .WillOnce(Return(true));
435 packet_router_.SendPacket(std::move(packet), PacedPacketInfo());
436
437 packet_router_.RemoveSendRtpModule(&rtp);
438 }
439
TEST_F(PacketRouterTest,ForwardsAbortedRetransmissions)440 TEST_F(PacketRouterTest, ForwardsAbortedRetransmissions) {
441 NiceMock<MockRtpRtcpInterface> rtp_1;
442 NiceMock<MockRtpRtcpInterface> rtp_2;
443
444 const uint32_t kSsrc1 = 1234;
445 const uint32_t kSsrc2 = 2345;
446 const uint32_t kInvalidSsrc = 3456;
447
448 ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1));
449 ON_CALL(rtp_2, SSRC).WillByDefault(Return(kSsrc2));
450
451 packet_router_.AddSendRtpModule(&rtp_1, false);
452 packet_router_.AddSendRtpModule(&rtp_2, false);
453
454 // Sets of retransmission sequence numbers we wish to abort, per ssrc.
455 const uint16_t kAbortedRetransmissionsOnSsrc1[] = {17, 42};
456 const uint16_t kAbortedRetransmissionsOnSsrc2[] = {1337, 4711};
457 const uint16_t kAbortedRetransmissionsOnSsrc3[] = {123};
458
459 EXPECT_CALL(rtp_1, OnAbortedRetransmissions(
460 ElementsAreArray(kAbortedRetransmissionsOnSsrc1)));
461 EXPECT_CALL(rtp_2, OnAbortedRetransmissions(
462 ElementsAreArray(kAbortedRetransmissionsOnSsrc2)));
463
464 packet_router_.OnAbortedRetransmissions(kSsrc1,
465 kAbortedRetransmissionsOnSsrc1);
466 packet_router_.OnAbortedRetransmissions(kSsrc2,
467 kAbortedRetransmissionsOnSsrc2);
468
469 // Should be noop and not cause any issues.
470 packet_router_.OnAbortedRetransmissions(kInvalidSsrc,
471 kAbortedRetransmissionsOnSsrc3);
472
473 packet_router_.RemoveSendRtpModule(&rtp_1);
474 packet_router_.RemoveSendRtpModule(&rtp_2);
475 }
476
TEST_F(PacketRouterTest,ReportsRtxSsrc)477 TEST_F(PacketRouterTest, ReportsRtxSsrc) {
478 NiceMock<MockRtpRtcpInterface> rtp_1;
479 NiceMock<MockRtpRtcpInterface> rtp_2;
480
481 const uint32_t kSsrc1 = 1234;
482 const uint32_t kRtxSsrc1 = 1235;
483 const uint32_t kSsrc2 = 2345;
484 const uint32_t kInvalidSsrc = 3456;
485
486 ON_CALL(rtp_1, SSRC).WillByDefault(Return(kSsrc1));
487 ON_CALL(rtp_1, RtxSsrc).WillByDefault(Return(kRtxSsrc1));
488 ON_CALL(rtp_2, SSRC).WillByDefault(Return(kSsrc2));
489
490 packet_router_.AddSendRtpModule(&rtp_1, false);
491 packet_router_.AddSendRtpModule(&rtp_2, false);
492
493 EXPECT_EQ(packet_router_.GetRtxSsrcForMedia(kSsrc1), kRtxSsrc1);
494 EXPECT_EQ(packet_router_.GetRtxSsrcForMedia(kRtxSsrc1), absl::nullopt);
495 EXPECT_EQ(packet_router_.GetRtxSsrcForMedia(kSsrc2), absl::nullopt);
496 EXPECT_EQ(packet_router_.GetRtxSsrcForMedia(kInvalidSsrc), absl::nullopt);
497
498 packet_router_.RemoveSendRtpModule(&rtp_1);
499 packet_router_.RemoveSendRtpModule(&rtp_2);
500 }
501
502 #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
503 using PacketRouterDeathTest = PacketRouterTest;
TEST_F(PacketRouterDeathTest,DoubleRegistrationOfSendModuleDisallowed)504 TEST_F(PacketRouterDeathTest, DoubleRegistrationOfSendModuleDisallowed) {
505 NiceMock<MockRtpRtcpInterface> module;
506
507 constexpr bool remb_candidate = false; // Value irrelevant.
508 packet_router_.AddSendRtpModule(&module, remb_candidate);
509 EXPECT_DEATH(packet_router_.AddSendRtpModule(&module, remb_candidate), "");
510
511 // Test tear-down
512 packet_router_.RemoveSendRtpModule(&module);
513 }
514
TEST_F(PacketRouterDeathTest,DoubleRegistrationOfReceiveModuleDisallowed)515 TEST_F(PacketRouterDeathTest, DoubleRegistrationOfReceiveModuleDisallowed) {
516 NiceMock<MockRtpRtcpInterface> module;
517
518 constexpr bool remb_candidate = false; // Value irrelevant.
519 packet_router_.AddReceiveRtpModule(&module, remb_candidate);
520 EXPECT_DEATH(packet_router_.AddReceiveRtpModule(&module, remb_candidate), "");
521
522 // Test tear-down
523 packet_router_.RemoveReceiveRtpModule(&module);
524 }
525
TEST_F(PacketRouterDeathTest,RemovalOfNeverAddedSendModuleDisallowed)526 TEST_F(PacketRouterDeathTest, RemovalOfNeverAddedSendModuleDisallowed) {
527 NiceMock<MockRtpRtcpInterface> module;
528
529 EXPECT_DEATH(packet_router_.RemoveSendRtpModule(&module), "");
530 }
531
TEST_F(PacketRouterDeathTest,RemovalOfNeverAddedReceiveModuleDisallowed)532 TEST_F(PacketRouterDeathTest, RemovalOfNeverAddedReceiveModuleDisallowed) {
533 NiceMock<MockRtpRtcpInterface> module;
534
535 EXPECT_DEATH(packet_router_.RemoveReceiveRtpModule(&module), "");
536 }
537 #endif // RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
538
TEST(PacketRouterRembTest,ChangeSendRtpModuleChangeRembSender)539 TEST(PacketRouterRembTest, ChangeSendRtpModuleChangeRembSender) {
540 rtc::ScopedFakeClock clock;
541 NiceMock<MockRtpRtcpInterface> rtp_send;
542 NiceMock<MockRtpRtcpInterface> rtp_recv;
543 PacketRouter packet_router;
544 packet_router.AddSendRtpModule(&rtp_send, true);
545 packet_router.AddReceiveRtpModule(&rtp_recv, true);
546
547 uint32_t bitrate_estimate = 456;
548 std::vector<uint32_t> ssrcs = {1234, 5678};
549
550 EXPECT_CALL(rtp_send, SetRemb(bitrate_estimate, ssrcs));
551 packet_router.SendRemb(bitrate_estimate, ssrcs);
552
553 // Remove the sending module -> should get remb on the second module.
554 packet_router.RemoveSendRtpModule(&rtp_send);
555
556 EXPECT_CALL(rtp_recv, SetRemb(bitrate_estimate, ssrcs));
557 packet_router.SendRemb(bitrate_estimate, ssrcs);
558
559 packet_router.RemoveReceiveRtpModule(&rtp_recv);
560 }
561
562 // Only register receiving modules and make sure we fallback to trigger a REMB
563 // packet on this one.
TEST(PacketRouterRembTest,NoSendingRtpModule)564 TEST(PacketRouterRembTest, NoSendingRtpModule) {
565 rtc::ScopedFakeClock clock;
566 NiceMock<MockRtpRtcpInterface> rtp;
567 PacketRouter packet_router;
568
569 packet_router.AddReceiveRtpModule(&rtp, true);
570
571 uint32_t bitrate_estimate = 456;
572 const std::vector<uint32_t> ssrcs = {1234};
573
574 EXPECT_CALL(rtp, SetRemb(bitrate_estimate, ssrcs));
575 packet_router.SendRemb(bitrate_estimate, ssrcs);
576
577 // Lower the estimate to trigger a new packet REMB packet.
578 EXPECT_CALL(rtp, SetRemb(bitrate_estimate, ssrcs));
579 packet_router.SendRemb(bitrate_estimate, ssrcs);
580
581 EXPECT_CALL(rtp, UnsetRemb());
582 packet_router.RemoveReceiveRtpModule(&rtp);
583 }
584
TEST(PacketRouterRembTest,NonCandidateSendRtpModuleNotUsedForRemb)585 TEST(PacketRouterRembTest, NonCandidateSendRtpModuleNotUsedForRemb) {
586 rtc::ScopedFakeClock clock;
587 PacketRouter packet_router;
588 NiceMock<MockRtpRtcpInterface> module;
589
590 constexpr bool remb_candidate = false;
591
592 packet_router.AddSendRtpModule(&module, remb_candidate);
593
594 constexpr uint32_t bitrate_estimate = 456;
595 const std::vector<uint32_t> ssrcs = {1234};
596 EXPECT_CALL(module, SetRemb(_, _)).Times(0);
597 packet_router.SendRemb(bitrate_estimate, ssrcs);
598
599 // Test tear-down
600 packet_router.RemoveSendRtpModule(&module);
601 }
602
TEST(PacketRouterRembTest,CandidateSendRtpModuleUsedForRemb)603 TEST(PacketRouterRembTest, CandidateSendRtpModuleUsedForRemb) {
604 rtc::ScopedFakeClock clock;
605 PacketRouter packet_router;
606 NiceMock<MockRtpRtcpInterface> module;
607
608 constexpr bool remb_candidate = true;
609
610 packet_router.AddSendRtpModule(&module, remb_candidate);
611
612 constexpr uint32_t bitrate_estimate = 456;
613 const std::vector<uint32_t> ssrcs = {1234};
614 EXPECT_CALL(module, SetRemb(bitrate_estimate, ssrcs));
615 packet_router.SendRemb(bitrate_estimate, ssrcs);
616
617 // Test tear-down
618 packet_router.RemoveSendRtpModule(&module);
619 }
620
TEST(PacketRouterRembTest,NonCandidateReceiveRtpModuleNotUsedForRemb)621 TEST(PacketRouterRembTest, NonCandidateReceiveRtpModuleNotUsedForRemb) {
622 rtc::ScopedFakeClock clock;
623 PacketRouter packet_router;
624 NiceMock<MockRtpRtcpInterface> module;
625
626 constexpr bool remb_candidate = false;
627
628 packet_router.AddReceiveRtpModule(&module, remb_candidate);
629
630 constexpr uint32_t bitrate_estimate = 456;
631 const std::vector<uint32_t> ssrcs = {1234};
632 EXPECT_CALL(module, SetRemb(_, _)).Times(0);
633 packet_router.SendRemb(bitrate_estimate, ssrcs);
634
635 // Test tear-down
636 packet_router.RemoveReceiveRtpModule(&module);
637 }
638
TEST(PacketRouterRembTest,CandidateReceiveRtpModuleUsedForRemb)639 TEST(PacketRouterRembTest, CandidateReceiveRtpModuleUsedForRemb) {
640 rtc::ScopedFakeClock clock;
641 PacketRouter packet_router;
642 NiceMock<MockRtpRtcpInterface> module;
643
644 constexpr bool remb_candidate = true;
645
646 packet_router.AddReceiveRtpModule(&module, remb_candidate);
647
648 constexpr uint32_t bitrate_estimate = 456;
649 const std::vector<uint32_t> ssrcs = {1234};
650 EXPECT_CALL(module, SetRemb(bitrate_estimate, ssrcs));
651 packet_router.SendRemb(bitrate_estimate, ssrcs);
652
653 // Test tear-down
654 packet_router.RemoveReceiveRtpModule(&module);
655 }
656
TEST(PacketRouterRembTest,SendCandidatePreferredOverReceiveCandidate_SendModuleAddedFirst)657 TEST(PacketRouterRembTest,
658 SendCandidatePreferredOverReceiveCandidate_SendModuleAddedFirst) {
659 rtc::ScopedFakeClock clock;
660 PacketRouter packet_router;
661 NiceMock<MockRtpRtcpInterface> send_module;
662 NiceMock<MockRtpRtcpInterface> receive_module;
663
664 constexpr bool remb_candidate = true;
665
666 // Send module added - activated.
667 packet_router.AddSendRtpModule(&send_module, remb_candidate);
668
669 // Receive module added - the send module remains the active one.
670 packet_router.AddReceiveRtpModule(&receive_module, remb_candidate);
671
672 constexpr uint32_t bitrate_estimate = 456;
673 const std::vector<uint32_t> ssrcs = {1234};
674 EXPECT_CALL(send_module, SetRemb(bitrate_estimate, ssrcs));
675 EXPECT_CALL(receive_module, SetRemb(_, _)).Times(0);
676
677 packet_router.SendRemb(bitrate_estimate, ssrcs);
678
679 // Test tear-down
680 packet_router.RemoveReceiveRtpModule(&receive_module);
681 packet_router.RemoveSendRtpModule(&send_module);
682 }
683
TEST(PacketRouterRembTest,SendCandidatePreferredOverReceiveCandidate_ReceiveModuleAddedFirst)684 TEST(PacketRouterRembTest,
685 SendCandidatePreferredOverReceiveCandidate_ReceiveModuleAddedFirst) {
686 rtc::ScopedFakeClock clock;
687 PacketRouter packet_router;
688 NiceMock<MockRtpRtcpInterface> send_module;
689 NiceMock<MockRtpRtcpInterface> receive_module;
690
691 constexpr bool remb_candidate = true;
692
693 // Receive module added - activated.
694 packet_router.AddReceiveRtpModule(&receive_module, remb_candidate);
695
696 // Send module added - replaces receive module as active.
697 packet_router.AddSendRtpModule(&send_module, remb_candidate);
698
699 constexpr uint32_t bitrate_estimate = 456;
700 const std::vector<uint32_t> ssrcs = {1234};
701 EXPECT_CALL(send_module, SetRemb(bitrate_estimate, ssrcs));
702 EXPECT_CALL(receive_module, SetRemb(_, _)).Times(0);
703
704 clock.AdvanceTime(TimeDelta::Millis(1000));
705 packet_router.SendRemb(bitrate_estimate, ssrcs);
706
707 // Test tear-down
708 packet_router.RemoveReceiveRtpModule(&receive_module);
709 packet_router.RemoveSendRtpModule(&send_module);
710 }
711
TEST(PacketRouterRembTest,ReceiveModuleTakesOverWhenLastSendModuleRemoved)712 TEST(PacketRouterRembTest, ReceiveModuleTakesOverWhenLastSendModuleRemoved) {
713 rtc::ScopedFakeClock clock;
714 PacketRouter packet_router;
715 NiceMock<MockRtpRtcpInterface> send_module;
716 NiceMock<MockRtpRtcpInterface> receive_module;
717
718 constexpr bool remb_candidate = true;
719
720 // Send module active, receive module inactive.
721 packet_router.AddSendRtpModule(&send_module, remb_candidate);
722 packet_router.AddReceiveRtpModule(&receive_module, remb_candidate);
723
724 // Send module removed - receive module becomes active.
725 packet_router.RemoveSendRtpModule(&send_module);
726 constexpr uint32_t bitrate_estimate = 456;
727 const std::vector<uint32_t> ssrcs = {1234};
728 EXPECT_CALL(send_module, SetRemb(_, _)).Times(0);
729 EXPECT_CALL(receive_module, SetRemb(bitrate_estimate, ssrcs));
730 packet_router.SendRemb(bitrate_estimate, ssrcs);
731
732 // Test tear-down
733 packet_router.RemoveReceiveRtpModule(&receive_module);
734 }
735
736 } // namespace webrtc
737