1commit 0cb6965869ab94858d9b843ab5d94f7deaea5dc8 2Author: Fabian Meumertzheim <[email protected]> 3Date: Mon Jun 12 16:12:02 2023 +0200 4 5 Disable layering_check 6 7 protobuf misses a sizeable number of dependency declarations, which 8 means that `layering_check` has to be disabled for it. 9 10 Generated with: 11 ``` 12 buildozer 'add features -layering_check' //src/...:__pkg__ 13 ``` 14 15 Contains only the changes to `package` directives. 16 17diff --git src/BUILD.bazel src/BUILD.bazel 18index 0de1a4eb1..b7e405147 100644 19--- src/BUILD.bazel 20+++ src/BUILD.bazel 21@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_filegroup", "pkg_files", "strip_prefix") 22 load("@upb//cmake:build_defs.bzl", "staleness_test") 23 load("//conformance:defs.bzl", "conformance_test") 24 25+package(features = ["-layering_check"]) 26+ 27 pkg_files( 28 name = "dist_files", 29 srcs = glob(["**"]), 30diff --git src/google/protobuf/BUILD.bazel src/google/protobuf/BUILD.bazel 31index 77ed2309f..8c38fb872 100644 32--- src/google/protobuf/BUILD.bazel 33+++ src/google/protobuf/BUILD.bazel 34@@ -13,6 +13,7 @@ package( 35 "//:__pkg__", # "public" targets are alias rules in //. 36 "//json:__subpackages__", 37 ], 38+ features = ["-layering_check"], 39 ) 40 41 proto_library( 42diff --git src/google/protobuf/compiler/BUILD.bazel src/google/protobuf/compiler/BUILD.bazel 43index a2171c806..8dcd34667 100644 44--- src/google/protobuf/compiler/BUILD.bazel 45+++ src/google/protobuf/compiler/BUILD.bazel 46@@ -13,6 +13,8 @@ load("@rules_proto//proto:defs.bzl", "proto_library") 47 load("//build_defs:arch_tests.bzl", "aarch64_test", "x86_64_test") 48 load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS") 49 50+package(features = ["-layering_check"]) 51+ 52 proto_library( 53 name = "plugin_proto", 54 srcs = ["plugin.proto"], 55diff --git src/google/protobuf/compiler/allowlists/BUILD.bazel src/google/protobuf/compiler/allowlists/BUILD.bazel 56index 569a142fc..0a90b312f 100644 57--- src/google/protobuf/compiler/allowlists/BUILD.bazel 58+++ src/google/protobuf/compiler/allowlists/BUILD.bazel 59@@ -1,7 +1,10 @@ 60 load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 61 load("//build_defs:cpp_opts.bzl", "COPTS") 62 63-package(default_visibility = ["//visibility:private"]) 64+package( 65+ default_visibility = ["//visibility:private"], 66+ features = ["-layering_check"], 67+) 68 69 cc_library( 70 name = "allowlist", 71diff --git src/google/protobuf/compiler/cpp/BUILD.bazel src/google/protobuf/compiler/cpp/BUILD.bazel 72index ac1184d32..deacbf582 100644 73--- src/google/protobuf/compiler/cpp/BUILD.bazel 74+++ src/google/protobuf/compiler/cpp/BUILD.bazel 75@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 76 load("@rules_proto//proto:defs.bzl", "proto_library") 77 load("//build_defs:cpp_opts.bzl", "COPTS") 78 79+package(features = ["-layering_check"]) 80+ 81 cc_library( 82 name = "names", 83 hdrs = ["names.h"], 84diff --git src/google/protobuf/compiler/csharp/BUILD.bazel src/google/protobuf/compiler/csharp/BUILD.bazel 85index 96b8dcbc0..a2d549f26 100644 86--- src/google/protobuf/compiler/csharp/BUILD.bazel 87+++ src/google/protobuf/compiler/csharp/BUILD.bazel 88@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 89 load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 90 load("//build_defs:cpp_opts.bzl", "COPTS") 91 92+package(features = ["-layering_check"]) 93+ 94 cc_library( 95 name = "names", 96 hdrs = ["names.h"], 97diff --git src/google/protobuf/compiler/java/BUILD.bazel src/google/protobuf/compiler/java/BUILD.bazel 98index 94573892c..c94f472d6 100644 99--- src/google/protobuf/compiler/java/BUILD.bazel 100+++ src/google/protobuf/compiler/java/BUILD.bazel 101@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 102 load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 103 load("//build_defs:cpp_opts.bzl", "COPTS") 104 105+package(features = ["-layering_check"]) 106+ 107 cc_library( 108 name = "names", 109 hdrs = ["names.h"], 110diff --git src/google/protobuf/compiler/objectivec/BUILD.bazel src/google/protobuf/compiler/objectivec/BUILD.bazel 111index f78990394..6c534219a 100644 112--- src/google/protobuf/compiler/objectivec/BUILD.bazel 113+++ src/google/protobuf/compiler/objectivec/BUILD.bazel 114@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 115 load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 116 load("//build_defs:cpp_opts.bzl", "COPTS") 117 118+package(features = ["-layering_check"]) 119+ 120 cc_library( 121 name = "names", 122 hdrs = ["names.h"], 123diff --git src/google/protobuf/compiler/php/BUILD.bazel src/google/protobuf/compiler/php/BUILD.bazel 124index fe9e75c2c..a569a1c9d 100644 125--- src/google/protobuf/compiler/php/BUILD.bazel 126+++ src/google/protobuf/compiler/php/BUILD.bazel 127@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library") 128 load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 129 load("//build_defs:cpp_opts.bzl", "COPTS") 130 131+package(features = ["-layering_check"]) 132+ 133 cc_library( 134 name = "names", 135 hdrs = ["names.h"], 136diff --git src/google/protobuf/compiler/python/BUILD.bazel src/google/protobuf/compiler/python/BUILD.bazel 137index 5d26e0ce9..ce017acf1 100644 138--- src/google/protobuf/compiler/python/BUILD.bazel 139+++ src/google/protobuf/compiler/python/BUILD.bazel 140@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 141 load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 142 load("//build_defs:cpp_opts.bzl", "COPTS") 143 144+package(features = ["-layering_check"]) 145+ 146 cc_library( 147 name = "python", 148 srcs = [ 149diff --git src/google/protobuf/compiler/ruby/BUILD.bazel src/google/protobuf/compiler/ruby/BUILD.bazel 150index 520b69194..1e437e7bc 100644 151--- src/google/protobuf/compiler/ruby/BUILD.bazel 152+++ src/google/protobuf/compiler/ruby/BUILD.bazel 153@@ -6,6 +6,8 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 154 load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 155 load("//build_defs:cpp_opts.bzl", "COPTS") 156 157+package(features = ["-layering_check"]) 158+ 159 cc_library( 160 name = "ruby", 161 srcs = ["ruby_generator.cc"], 162diff --git src/google/protobuf/compiler/rust/BUILD.bazel src/google/protobuf/compiler/rust/BUILD.bazel 163index 7c1f5b856..4a10038d1 100644 164--- src/google/protobuf/compiler/rust/BUILD.bazel 165+++ src/google/protobuf/compiler/rust/BUILD.bazel 166@@ -5,6 +5,8 @@ 167 load("@rules_cc//cc:defs.bzl", "cc_library") 168 load("//build_defs:cpp_opts.bzl", "COPTS") 169 170+package(features = ["-layering_check"]) 171+ 172 cc_library( 173 name = "rust", 174 srcs = ["generator.cc"], 175diff --git src/google/protobuf/io/BUILD.bazel src/google/protobuf/io/BUILD.bazel 176index 8f39625c2..fc2f8e002 100644 177--- src/google/protobuf/io/BUILD.bazel 178+++ src/google/protobuf/io/BUILD.bazel 179@@ -6,6 +6,7 @@ load("//build_defs:cpp_opts.bzl", "COPTS") 180 181 package( 182 default_visibility = ["//visibility:public"], 183+ features = ["-layering_check"], 184 ) 185 186 cc_library( 187diff --git src/google/protobuf/json/BUILD.bazel src/google/protobuf/json/BUILD.bazel 188index d6019f939..83caca985 100644 189--- src/google/protobuf/json/BUILD.bazel 190+++ src/google/protobuf/json/BUILD.bazel 191@@ -1,10 +1,13 @@ 192 load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test") 193 load("//build_defs:cpp_opts.bzl", "COPTS") 194 195-package(default_visibility = [ 196- "//pkg:__pkg__", 197- "//src/google/protobuf/json:__pkg__", 198-]) 199+package( 200+ default_visibility = [ 201+ "//pkg:__pkg__", 202+ "//src/google/protobuf/json:__pkg__", 203+ ], 204+ features = ["-layering_check"], 205+) 206 207 licenses(["notice"]) 208 209diff --git src/google/protobuf/stubs/BUILD.bazel src/google/protobuf/stubs/BUILD.bazel 210index c8fc3e9d0..9521f5103 100644 211--- src/google/protobuf/stubs/BUILD.bazel 212+++ src/google/protobuf/stubs/BUILD.bazel 213@@ -7,6 +7,7 @@ load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS") 214 215 package( 216 default_visibility = ["//:__subpackages__"], 217+ features = ["-layering_check"], 218 ) 219 220 cc_library( 221diff --git src/google/protobuf/testing/BUILD.bazel src/google/protobuf/testing/BUILD.bazel 222index 572c1f9f4..d10435cce 100644 223--- src/google/protobuf/testing/BUILD.bazel 224+++ src/google/protobuf/testing/BUILD.bazel 225@@ -5,7 +5,10 @@ load("@rules_cc//cc:defs.bzl", "cc_library") 226 load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 227 load("//build_defs:cpp_opts.bzl", "COPTS", "LINK_OPTS") 228 229-package(default_visibility = ["//:__subpackages__"]) 230+package( 231+ default_visibility = ["//:__subpackages__"], 232+ features = ["-layering_check"], 233+) 234 235 cc_library( 236 name = "testing", 237diff --git src/google/protobuf/util/BUILD.bazel src/google/protobuf/util/BUILD.bazel 238index 3afe464cf..03a3045b3 100644 239--- src/google/protobuf/util/BUILD.bazel 240+++ src/google/protobuf/util/BUILD.bazel 241@@ -7,6 +7,8 @@ load("@rules_pkg//:mappings.bzl", "pkg_files", "strip_prefix") 242 load("@rules_proto//proto:defs.bzl", "proto_library") 243 load("//build_defs:cpp_opts.bzl", "COPTS") 244 245+package(features = ["-layering_check"]) 246+ 247 cc_library( 248 name = "delimited_message_util", 249 srcs = ["delimited_message_util.cc"], 250